Fix discarded notification observers in StatsWidgetsStore #20995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20995-66ff6fb | |
| Version | 22.7 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 66ff6fb | |
| App Center Build | WPiOS - One-Offs #6201 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20995-66ff6fb | |
| Version | 22.7 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 66ff6fb | |
| App Center Build | jetpack-installable-builds #5227 |
mokagio
approved these changes
Jul 4, 2023
Comment on lines
265
to
272
| UserDefaults(suiteName: WPAppGroupName)?.setValue(AccountHelper.isLoggedIn, forKey: AppConfiguration.Widget.Stats.userDefaultsLoggedInKey) | ||
|
|
||
| if !AccountHelper.isLoggedIn { | ||
| HomeWidgetTodayData.delete() | ||
| HomeWidgetThisWeekData.delete() | ||
| HomeWidgetAllTimeData.delete() | ||
| if !AccountHelper.isLoggedIn { | ||
| HomeWidgetTodayData.delete() | ||
| HomeWidgetThisWeekData.delete() | ||
| HomeWidgetAllTimeData.delete() | ||
|
|
||
| UserDefaults(suiteName: WPAppGroupName)?.setValue(nil, forKey: AppConfiguration.Widget.Stats.userDefaultsSiteIdKey) | ||
| WidgetCenter.shared.reloadTimelines(ofKind: AppConfiguration.Widget.Stats.todayKind) | ||
| WidgetCenter.shared.reloadTimelines(ofKind: AppConfiguration.Widget.Stats.thisWeekKind) | ||
| WidgetCenter.shared.reloadTimelines(ofKind: AppConfiguration.Widget.Stats.allTimeKind) | ||
| } | ||
| UserDefaults(suiteName: WPAppGroupName)?.setValue(nil, forKey: AppConfiguration.Widget.Stats.userDefaultsSiteIdKey) |
There was a problem hiding this comment.
One could DRY and this a tiny bit by storing the UserDefatuls instance and adding an early return
let defaults = UserDefaults(suiteName: WPAppGroupName)
defaults.setValue...
guard !AccountHelper.isLoggedIn else { return }
...🤷♂️
There was a problem hiding this comment.
Addressed in 66ff6fb
jkmassel
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #20994.
This PR changes to use
StatsWidgetsStoreas notification observers, so thatNSNotificationCenterautomatically unregister the observer when the store instance is released.StatsWidgetsStoreis currently a singleton, so technically there is no issue with current code and this PR has no effect at all to the app. However,StatsWidgetsStoremay get to escape from theStoreContainersingleton and the issue with notification observers will arise then. Also, we should not discard notification observers anyways.Regression Notes
Potential unintended areas of impact
None.
What I did to test those areas of impact (or what existing automated tests I relied on)
Log in and log out.
What automated tests I added (or what prevented me from doing so)
None.
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: N/A