Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Core Data threading issue in ThemeService #20828

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Fix Core Data threading issue in ThemeService #20828

merged 1 commit into from
Jun 12, 2023

Conversation

kean
Copy link
Contributor

@kean kean commented Jun 9, 2023 •
edited
Loading

Fixes an issue where ThemeService was accessing a blog object from the main thread in the background context.

Steps to reproduce:

  • Run the app with Xcode debugger attached
  • Open a site that doesn't support custom themes that has unsynced themes
  • Open Menu / Themes

Actual result:

  • Xcode reports invalid Core Data usage

Regression Notes

  1. Potential unintended areas of impact: Menu / Themes
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual test
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 9, 2023 •
edited
Loading

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@kean kean requested a review from crazytonyli June 9, 2023 15:34
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20828-5f90755
Version22.5
Bundle IDorg.wordpress.alpha
Commit5f90755
App Center BuildWPiOS - One-Offs #5918
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20828-5f90755
Version22.5
Bundle IDcom.jetpack.alpha
Commit5f90755
App Center Buildjetpack-installable-builds #4946
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean added this to the Someday milestone Jun 9, 2023
crazytonyli
crazytonyli approved these changes Jun 11, 2023
View reviewed changes
Copy link
Contributor

@crazytonyli crazytonyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a typical "using a wrong variable" bug to me 🥲

Thanks for the fix!

@kean kean merged commit b9a9ee8 into trunk Jun 12, 2023
@kean kean deleted the fix/crash-when-opening-themes branch June 12, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazytonyli crazytonyli crazytonyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Someday
Development

Successfully merging this pull request may close these issues.
3 participants
@kean @wpmobilebot @crazytonyli