Send Slack notification for UI/Unit test failures #20793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20793-62594e4 | |
| Version | 22.5 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 62594e4 | |
| App Center Build | jetpack-installable-builds #4868 |
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20793-62594e4 | |
| Version | 22.5 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 62594e4 | |
| App Center Build | WPiOS - One-Offs #5838 |
AliSoftware
approved these changes
Jun 2, 2023
| @@ -73,10 +73,6 @@ steps: | |||
| notify: | |||
| - github_commit_status: | |||
| context: "Unit Tests" | |||
| - slack: | |||
| channels: | |||
| - "#mobile-apps-tests-notif" | |||
There was a problem hiding this comment.
Just checking that it was intentional (and not a copy/paste typo) that you changed the channel used in the call to annotate_test_failures and now send the notification to #build-and-ship… while previously it was sent to this other channel?
There was a problem hiding this comment.
thanks for checking! yup this is intentional. speaking with @pachlava and @tiagomar, we decided to post this on #build-and-ship since that's the channel we're monitoring now - better to have it in one channel rather than multiple. with this, we would immediately know if a build is failing because of tests or other steps from this notification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Same changes as This PR updates the
a8c-ci-toolkitto v2.17.0 to get the updated version ofannotate_test_failuresutility. With this change, any test failures (UI and Unit) on merges totrunkorrelease/*branches will send a slack notification tobuild-and-shipchannel.I also removed Buildkite's Slack notification for UI and Unit test steps that was previously added via #19181 and #19120 as this new notification will replace that.
Similar PR for WCiOS: woocommerce/woocommerce-ios#9853