Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test – Point Gutenberg to a commit to verify XCFramework setup #20792

Closed
wants to merge 16 commits into from
Closed

Test – Point Gutenberg to a commit to verify XCFramework setup #20792

wants to merge 16 commits into from

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Jun 2, 2023

No description provided.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 2, 2023 •
edited
Loading

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@mokagio mokagio mentioned this pull request Jun 2, 2023
Closed
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 2, 2023 •
edited
Loading

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20792-fe3dcb4
Version22.6
Bundle IDcom.jetpack.alpha
Commitfe3dcb4
App Center Buildjetpack-installable-builds #4973
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio mokagio force-pushed the test/gutenberg-xcframework-setup-take-2 branch from 9f9705b to 4285356 Compare June 5, 2023 04:44
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 5, 2023 •
edited
Loading

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20792-fe3dcb4
Version22.6
Bundle IDorg.wordpress.alpha
Commitfe3dcb4
App Center BuildWPiOS - One-Offs #5945
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio mokagio mentioned this pull request Jun 5, 2023
Merged
2 tasks
@mokagio mokagio force-pushed the mokagio/gutenberg-xcframework-setup branch 5 times, most recently from b491550 to 9a84116 Compare June 8, 2023 05:34
@mokagio mokagio force-pushed the test/gutenberg-xcframework-setup-take-2 branch from 4285356 to ffe2be9 Compare June 8, 2023 05:38
@mokagio mokagio force-pushed the mokagio/gutenberg-xcframework-setup branch from 9a84116 to f1d63c1 Compare June 11, 2023 21:13
@mokagio mokagio force-pushed the test/gutenberg-xcframework-setup-take-2 branch from 243f5ea to 9386931 Compare June 11, 2023 21:23
wpmobilebot
wpmobilebot reviewed Jun 11, 2023
View reviewed changes
Gutenberg/version.rb Outdated Show resolved Hide resolved
@mokagio
Add a local podspec to download Gutenberg XCFramework commit builds
bbc4928
@mokagio
Add check to fail pod install if Gutenberg ZIP doesn't exist at URL
12da230
@mokagio
Use latest CocoaPods version
c1d1bfe 
No other than reason than me looking at the CocoaPods setup and
realizing we were a few versions behind.
@mokagio
Switch to tar.gz for the Gutenberg XCFramework archive
7063b96 
Despite it working during the prototype stage, I wasn't able to get the
XCFrameworks out of the ZIP archive, but it works fine with the tar.gz.

I suspect this has to do with the folder(s) generated when
decompressing.
@mokagio
Use same license as the main project for the Gutenberg pod
34c991a
@mokagio
Work around CP not finding XCFrameworks by downloading manually
a05f59b
@mokagio
Add a couple of newly required import React
724b2d0 
These are unnecessary at the moment but will be when we move to
Gutenberg via XCFramework
@mokagio
Address new warnings introduced by the Gutenberg via XCFramework
ee303fa
@mokagio mokagio force-pushed the mokagio/gutenberg-xcframework-setup branch 2 times, most recently from 056d7c5 to 1df239d Compare June 13, 2023 03:58
@mokagio
Update CopyGutenbergJS build phase script to account for XCFramework
183e880
@mokagio
Use relative paths when importing the local Gutenberg podspec
93bc011
@mokagio
Remove pre_install download hook in favor of prepare_command
a1cb65b 
The advantage of this approach is that downloading the archive is only
necessary when using a local spec. Defining the logic in the local spec
itself keeps everything self contained and saves us from having to
conditionally call the `pre_install` hook.
@mokagio
Use remote spec instead of a local one for Gutenberg via commit
d0dd9b5 
The idea was to use a local spec and interpolated the desired commit
SHA1 in the `source` to download the corresponding `tar.gz`.

However, CocoaPods has some issues with local specs that use `http`
`source`, as documented in:

- CocoaPods/CocoaPods#10288 (comment)
- https://github.com/firebase/firebase-ios-sdk/blob/68b39b8edf61f6e643e2396e712c7c67e0f146ff/scripts/pod_lib_lint.rb#L70-L78

Using a remote spec doesn't have the same issue, and the cost in terms
of extra computation and storage is negligible when compared to building
and hosting the `tar.gz` archives.
@mokagio
Update Gutenberg tar.gz URL after changes in gutenberg-mobile
6f2a06e 
See
wordpress-mobile/gutenberg-mobile@57f9dd1
@mokagio
Use Xcode 14.3.1
af3b326 
This was done to address the following CI failure when building with the
Gutenberg XCFramework:

```
▸ Linking WordPress
⚠️  ld: Could not find or use auto-linked library 'swiftCompatibility56'

❌  ld: symbol(s) not found for architecture x86_64
```

https://buildkite.com/automattic/wordpress-ios/builds/14356#01885545-c05a-43a8-b475-d0d683857672
@mokagio mokagio force-pushed the mokagio/gutenberg-xcframework-setup branch from 1df239d to af3b326 Compare June 13, 2023 04:07
@mokagio mokagio force-pushed the test/gutenberg-xcframework-setup-take-2 branch from f14c5a5 to 5c50e63 Compare June 13, 2023 04:07
@mokagio mokagio mentioned this pull request Jun 13, 2023
Closed
4 tasks
@mokagio mokagio force-pushed the mokagio/gutenberg-xcframework-setup branch 3 times, most recently from 217e2fa to 5a3b0e8 Compare June 20, 2023 02:46
@mokagio mokagio force-pushed the mokagio/gutenberg-xcframework-setup branch from 5a3b0e8 to dec735b Compare June 21, 2023 11:47
@mokagio mokagio force-pushed the mokagio/gutenberg-xcframework-setup branch 2 times, most recently from 0f8cc00 to c2c46cc Compare July 3, 2023 05:52
@mokagio
Copy link
Contributor Author

mokagio commented Jul 18, 2023

Test "done". Closing.

@mokagio mokagio closed this Jul 18, 2023
@mokagio mokagio deleted the test/gutenberg-xcframework-setup-take-2 branch August 29, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpmobilebot wpmobilebot wpmobilebot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mokagio @wpmobilebot