Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Update site editor MVP to a remote feature flag and enable it #20713

Merged
merged 2 commits into from
May 19, 2023

Conversation

wargcm
Copy link
Contributor

@wargcm wargcm commented May 19, 2023

Description

Moves the site editor MVP feature flag to a remote feature flag and enables it by default.

Testing

To test:

  • Launch Jetpack and login
  • Select a blog with a block based theme
  • Tap on "Pages" on the Home dashboard
  • Verify the block based theme homepage cell appears in the "Published" pages

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wargcm wargcm added this to the 22.5 milestone May 19, 2023
@wargcm wargcm requested a review from dvdchr May 19, 2023 16:51
@wargcm wargcm self-assigned this May 19, 2023
Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20713-96ea007
Version22.4
Bundle IDcom.jetpack.alpha
Commit96ea007
App Center Buildjetpack-installable-builds #4769
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20713-96ea007
Version22.4
Bundle IDorg.wordpress.alpha
Commit96ea007
App Center BuildWPiOS - One-Offs #5739
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wargcm wargcm merged commit bd9c8b9 into trunk May 19, 2023
@wargcm wargcm deleted the task/enable-site-editor branch May 19, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants