Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all case _: with default: #20465

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Replace all case _: with default: #20465

merged 1 commit into from
Apr 3, 2023

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Apr 3, 2023

While case _ works, default is the recommended syntax.

See conversation at #20128 (comment)

Regression Notes

  1. Potential unintended areas of impact – N.A.
  2. What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
  3. What automated tests I added (or what prevented me from doing so) – N.A.
  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes. N.A.
  • I have considered adding accessibility improvements for my changes. N.A.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

@mokagio
Replace all case _: with default: – There was only one
06e2d26 
While `case _` works, `default` is the recommended syntax.

See conversation at
#20128 (comment)
@mokagio mokagio requested a review from a team as a code owner April 3, 2023 11:04
@mokagio mokagio enabled auto-merge April 3, 2023 11:04
@mokagio mokagio added this to the 22.2 milestone Apr 3, 2023
@mokagio mokagio added the Core label Apr 3, 2023
@mokagio mokagio requested a review from crazytonyli April 3, 2023 11:05
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20465-06e2d26
Version22.1
Bundle IDorg.wordpress.alpha
Commit06e2d26
App Center BuildWPiOS - One-Offs #5395
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20465-06e2d26
Version22.1
Bundle IDcom.jetpack.alpha
Commit06e2d26
App Center Buildjetpack-installable-builds #4423
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

pachlava
pachlava approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@pachlava pachlava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement @mokagio 👋

The app removal function still works on CI, so the PR is good to 🚀.

@mokagio mokagio merged commit ea0a309 into trunk Apr 3, 2023
@mokagio mokagio deleted the mokagio/remove-case-_ branch April 3, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pachlava pachlava pachlava approved these changes

@crazytonyli crazytonyli Awaiting requested review from crazytonyli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
22.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mokagio @wpmobilebot @pachlava