Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React Native Reanimated to 2.9.1-wp-3 #20034

Merged
merged 3 commits into from
Feb 2, 2023

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Jan 30, 2023

Related PR:

To test check the CI checks succeed and the editor opens correctly.

Regression Notes

  1. Potential unintended areas of impact
    Editor

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing and CI checks

  3. What automated tests I added (or what prevented me from doing so)
    None

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 30, 2023

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr20034-2d349f2 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 30, 2023

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr20034-2d349f2 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@geriux geriux marked this pull request as ready for review January 31, 2023 13:17
@SiobhyB SiobhyB self-requested a review January 31, 2023 15:17
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to wordpress-mobile/WordPress-Android#17846 (review): I installed the build from this PR and confirmed that the editor loads without crashing, and I couldn't spot any obvious issues with some light manual testing.

Approving, given the CI checks also pass and all looks good with the general changes in the Gutenberg PR.

Thanks for working on this, Gerardo! 🎉 🚀

@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@fluiddot fluiddot merged commit cbf46f0 into trunk Feb 2, 2023
@fluiddot fluiddot deleted the gutenberg/update-reanimated-to-2.9.1-wp-3 branch February 2, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants