Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jetpack] Content Migration App Appearance Fix #19841

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

alpavanoglu
Copy link
Contributor

Fixes #19783

To test:

  1. Set App Theme on WP to a specific value (not system default)
  2. Fresh install on JP
  3. Start Migration
  4. Verify JP app has the App Theme set from WP when the Migration is complete.

To test:

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@alpavanoglu alpavanoglu added this to the 21.4 ❄️ milestone Jan 4, 2023
@alpavanoglu alpavanoglu requested a review from twstokes January 4, 2023 14:45
@alpavanoglu alpavanoglu changed the base branch from trunk to release/21.4 January 4, 2023 14:46
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked for me @alpavanoglu! 🚀

I set WordPress to Dark Mode and when I migrated over to Jetpack it switched to Dark Mode.

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19841-69c8f2c on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19841-69c8f2c on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@twstokes twstokes merged commit dad3489 into release/21.4 Jan 4, 2023
@twstokes twstokes deleted the bug/content-migration-appearance-fix branch January 4, 2023 20:12
@spencertransier
Copy link
Contributor

This PR is included in the 21.4.0.3 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS - Investigate transferring the app settings
4 participants