-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Local Notifications and Flow for Blogging Reminders #19611
Merged
staskus
merged 8 commits into
trunk
from
issue/19560-disable-local-notif-blogging-reminders
Nov 17, 2022
Merged
Disable Local Notifications and Flow for Blogging Reminders #19611
staskus
merged 8 commits into
trunk
from
issue/19560-disable-local-notif-blogging-reminders
Nov 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogging reminders when feature not enabled
…ow appearance determined by FeatureFlag for blogging reminders
You can test the changes in WordPress from this Pull Request by:
|
You can test the changes in Jetpack from this Pull Request by:
|
staskus
approved these changes
Nov 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Blogging reminders don't appear in site stats ✅
- Blogging reminders don't appear in Push Notification settings ✅
- Blogging reminders don't appear after publishing a post ✅
- Blogging reminders don't appear after publishing a draft ✅
- Blogging reminders don't appear after scheduling them and then disabling WP notifications ✅
staskus
deleted the
issue/19560-disable-local-notif-blogging-reminders
branch
November 17, 2022 09:20
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables local notifications and flow prompts for blogging reminders based on the blogging reminders FeatureFlag.
Ref #19560
To test:
Setup
Enable FeatureFlag allowDisablingWPNotifications
Test on Device and run up WPiOS app -> Notifications -> Notification Settings and ensure the Allow Notifications switch at top is set to off
UI Notification Settings Test
Continuing your test on device in Notification Settings below the Allow Notifications UISwitch tap into one of your sites
Click on one of your Sites -> Push Notifications
Blogging Reminders should no longer be a row (you can compare to production AppStore app where Blogging Reminders is the last row)
Creating a new post
5. Create a new blog post and publish the post
6. Blogging reminder should not appear
Publish a draft post
7. Create a new blog post and save as a draft
8. Go to the main site page and choose Posts to view all the posts for the site of choice
9. Choose the Drafts tab. Find your draft post. Tap the … More button and tap Publish Now to publish the draft post
10. Blogging reminder should not appear
Site Stats
11. Uninstall / re-install the WP iOS app - this isn't necessary but I'd recommend in case you previously dismissed a Grow Audience card
12. Tap through to Stats for a site with hardly any traffic. The top card that will be displayed Grow your audience type card. Make sure that this card is not a Blogging Reminders card. Tap dismiss (screenshot below of what the Grow Audience card looks like and Dismiss button)
13. Navigate back to the main site page and back to Stats 3 or 4 times and each time dismiss the Grow Audience card and ensure the blogging reminders card does not appear
Regression Notes
Potential unintended areas of impact
Blogging Reminders
What I did to test those areas of impact (or what existing automated tests I relied on)
Tested on device and added a unit test
What automated tests I added (or what prevented me from doing so)
I added a Unit test
PR submission checklist:
RELEASE-NOTES.txt
if necessary.