Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Local Notifications and Flow for Blogging Reminders #19611

Merged
merged 8 commits into from
Nov 17, 2022

Conversation

sla8c
Copy link
Contributor

@sla8c sla8c commented Nov 16, 2022

This PR disables local notifications and flow prompts for blogging reminders based on the blogging reminders FeatureFlag.

Ref #19560

To test:
Setup

  1. Enable FeatureFlag allowDisablingWPNotifications

  2. Test on Device and run up WPiOS app -> Notifications -> Notification Settings and ensure the Allow Notifications switch at top is set to off

  3. UI Notification Settings Test

  4. Continuing your test on device in Notification Settings below the Allow Notifications UISwitch tap into one of your sites

  5. Click on one of your Sites -> Push Notifications

  6. Blogging Reminders should no longer be a row (you can compare to production AppStore app where Blogging Reminders is the last row)

Creating a new post
5. Create a new blog post and publish the post
6. Blogging reminder should not appear

Publish a draft post
7. Create a new blog post and save as a draft
8. Go to the main site page and choose Posts to view all the posts for the site of choice
9. Choose the Drafts tab. Find your draft post. Tap the … More button and tap Publish Now to publish the draft post
10. Blogging reminder should not appear

Site Stats
11. Uninstall / re-install the WP iOS app - this isn't necessary but I'd recommend in case you previously dismissed a Grow Audience card
12. Tap through to Stats for a site with hardly any traffic. The top card that will be displayed Grow your audience type card. Make sure that this card is not a Blogging Reminders card. Tap dismiss (screenshot below of what the Grow Audience card looks like and Dismiss button)
13. Navigate back to the main site page and back to Stats 3 or 4 times and each time dismiss the Grow Audience card and ensure the blogging reminders card does not appear

image

Regression Notes

  1. Potential unintended areas of impact
    Blogging Reminders

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Tested on device and added a unit test

  3. What automated tests I added (or what prevented me from doing so)
    I added a Unit test

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@sla8c sla8c requested review from staskus and guarani November 16, 2022 16:14
@sla8c sla8c self-assigned this Nov 16, 2022
@sla8c sla8c added this to the 21.3 milestone Nov 16, 2022
@sla8c sla8c marked this pull request as draft November 16, 2022 16:15
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 16, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19611-3d6c98c on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 16, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19611-3d6c98c on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@staskus staskus marked this pull request as ready for review November 17, 2022 08:20
Copy link
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Blogging reminders don't appear in site stats ✅
  • Blogging reminders don't appear in Push Notification settings ✅
  • Blogging reminders don't appear after publishing a post ✅
  • Blogging reminders don't appear after publishing a draft ✅
  • Blogging reminders don't appear after scheduling them and then disabling WP notifications ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants