-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak a localization to remove any assumption on "+" localization #19473
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
WordPress/WordPressTest/StatsSegmentedControlDataTests.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import Nimble | ||
| import XCTest | ||
| @testable import WordPress | ||
|
|
||
| class StatsSegmentedControlDataTests: XCTestCase { | ||
|
|
||
| func testDifferenceLabel() { | ||
| expect(StatsSegmentedControlData.fixture(difference: -12_345, differencePercent: -1).differenceLabel) | ||
| == "-12.3K (-1%)" | ||
| expect(StatsSegmentedControlData.fixture(difference: -12_345, differencePercent: 0).differenceLabel) | ||
| == "-12.3K" | ||
| expect(StatsSegmentedControlData.fixture(difference: -12_345, differencePercent: 1).differenceLabel) | ||
| == "-12.3K (1%)" | ||
| expect(StatsSegmentedControlData.fixture(difference: 0, differencePercent: -1).differenceLabel) | ||
| == "0 (-1%)" | ||
| expect(StatsSegmentedControlData.fixture(difference: 0, differencePercent: 0).differenceLabel) | ||
| == "0" | ||
| expect(StatsSegmentedControlData.fixture(difference: 0, differencePercent: 1).differenceLabel) | ||
| == "0 (1%)" | ||
| expect(StatsSegmentedControlData.fixture(difference: 12_345, differencePercent: -1).differenceLabel) | ||
| == "+12.3K (-1%)" | ||
| expect(StatsSegmentedControlData.fixture(difference: 12_345, differencePercent: 0).differenceLabel) | ||
| == "+12.3K" | ||
| expect(StatsSegmentedControlData.fixture(difference: 12_345, differencePercent: 1).differenceLabel) | ||
| == "+12.3K (1%)" | ||
| } | ||
| } | ||
|
|
||
| extension StatsSegmentedControlData { | ||
|
|
||
| static func fixture( | ||
| segmentTitle: String = "title", | ||
| segmentData: Int = 0, | ||
| segmentPrevData: Int = 1, | ||
| difference: Int = 2, | ||
| differenceText: String = "text", | ||
| differencePercent: Int = 3 | ||
| ) -> StatsSegmentedControlData { | ||
| StatsSegmentedControlData( | ||
| segmentTitle: segmentTitle, | ||
| segmentData: segmentData, | ||
| segmentPrevData: segmentPrevData, | ||
| difference: difference, | ||
| differenceText: differenceText, | ||
| differencePercent: differencePercent | ||
| ) | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I based this off @staskus suggestion but I decided to use a localized string in the case without the percentage as well, so that translators can apply the appropriate RTL.
I'm not actually sure whether that's necessary, though.
Maybe we should lean into
NumberFormattermore for this? There's definitely rooms for improvement and internal refactors. The new tests added in this diff will help us with that in the future.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. 👍 I think the solution makes sense. We improved it by using numbered positions, localized plus signs, and most importantly, having localized strings static and not dynamic.