Merge changes from beta 20.9.0.1 into trunk
#19438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pping-account-settings-menu-for-accounts-with-no-sites Fix crash on tapping Account Settings menu for accounts with no sites
Without any apparent change on our side, we saw a couple of Pocket Casts builds with unexpected, and unexpectedly incrementing, build numbers on TestFlight. From 7.24.0.3, to 8, to 9. This behavior could be replicated locally in that project by running the Fastlane automation, but not when archiving via Xcode. I pin pointed it to the `manageAppVersionAndBuildNumber` option being true by default in the `ExportOptions.plist` that Fastlane / `xcodebuild` generates for `gym` to convert an archive into an IPA. Explicitly setting the option to `false` solves the issue locally. See Automattic/pocket-casts-ios#373. To verify the issue on this project, checkout the current tip of the release branch, 838058f, and apply the following patch: ``` index 1c05a77b05..e3cb20e4ae 100644 --- a/fastlane/lanes/build.rb +++ b/fastlane/lanes/build.rb @@ -123,6 +123,8 @@ platform :ios do export_options: { method: 'app-store' } ) + UI.user_error! 'Aborting after building. This was just a test.' + testflight( skip_waiting_for_build_processing: true, team_id: get_required_env('FASTLANE_ITC_TEAM_ID'), @@ -173,6 +175,8 @@ platform :ios do export_options: { method: 'app-store' } ) + UI.user_error! 'Aborting after building. This was just a test.' + testflight( skip_waiting_for_build_processing: true, team_id: '299112', @@ -215,6 +219,8 @@ platform :ios do export_options: { method: 'enterprise' } ) + UI.user_error! 'Aborting after building. This was just a test.' + appcenter_upload( api_token: get_required_env('APPCENTER_API_TOKEN'), owner_name: APPCENTER_OWNER_NAME, @@ -264,6 +270,8 @@ platform :ios do export_options: { method: 'enterprise' } ) + UI.user_error! 'Aborting after building. This was just a test.' + appcenter_upload( api_token: get_required_env('APPCENTER_API_TOKEN'), owner_name: APPCENTER_OWNER_NAME, @@ -317,6 +325,8 @@ platform :ios do export_options: { method: 'enterprise' } ) + UI.user_error! 'Aborting after building. This was just a test.' + appcenter_upload( api_token: get_required_env('APPCENTER_API_TOKEN'), owner_name: APPCENTER_OWNER_NAME, ``` Run a lane to build a binary for App Store Connect (`method: 'app-store'`) and notice how the build number is `21` instead of the `20.9.0.0` coming from `config/Version.public.xcconfig`. ``` bundle exec fastlane build_and_upload_app_store_connect skip_confirm:true skip_prechecks:true ``` Conversely, a lane with `method: 'enterprise'` won't show that behavior: ``` bundle exec fastlane build_and_upload_app_center skip_confirm:true skip_prechecks:true ```
… is showing (#19417) * Explicitly set insights as selected period when grow audience is showing When we simply return, we can get into cases where selectedPeriod is not equal to .insights even though insights are open. In such an instance the tab switching doesn't work anymore. * Update expected Bundler to version 2.3.23 Co-authored-by: Gio Lodi <[email protected]>
This was referenced Oct 12, 2022
You can test the changes in Jetpack from this Pull Request by:
|
You can test the changes in WordPress from this Pull Request by:
|
AliSoftware
approved these changes
Oct 12, 2022
There was a problem hiding this comment.
👍
- Changes from bugfix PRs which landed in the release branch
- Version bump in
.xcconfigfiles - Latest app and metadata translations pulled from GlotPress
PS: 🤦 Facepalm moment from me while reviewing this…
Includes:
At first I thought that, while I saw #19418 in the list of commits, I didn't see #19417 so I thought it wasn't part of this PR unlike what was said in the PR description. I then thought maybe it was merged into trunk as part of a previous release/20.9->trunk PR hence why it wasn't there, but couldn't find it in any of those previous PRs…
It took me a minute to realize that #19417 was indeed part of this PR and in the commit list after all (unlike what I thought at first)… it's only that the reference to that PR number was hidden at first due to a long commit message being collapsed 😅 Once I saw in the 19417 PR which commit was associated with that PR being merged (namely, ac66570), and then found that commit in this PR's commit list and expanded the commit message details, it suddenly all made sense 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.stringsand Fastlane metadata) automatically pulled for the new translations that have already been approved in GlotPress.xcconfigIncludes: