Create a generic CoreDataQuery type
#19394
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,146 @@ | ||
| import Foundation | ||
|
|
||
| struct CoreDataQuery<Result: NSManagedObject> { | ||
| private var predicates = [NSPredicate]() | ||
| private var sortDescriptors = [NSSortDescriptor]() | ||
|
|
||
| private var includesSubentities: Bool = true | ||
|
|
||
| init() { | ||
| } | ||
|
|
||
| func ascending(by key: String) -> Self { | ||
| var query = self | ||
| query.sortDescriptors.append(NSSortDescriptor(key: key, ascending: true)) | ||
| return query | ||
| } | ||
|
|
||
| func descending(by key: String) -> Self { | ||
| var query = self | ||
| query.sortDescriptors.append(NSSortDescriptor(key: key, ascending: false)) | ||
| return query | ||
| } | ||
|
|
||
| func includesSubentities(_ value: Bool) -> Self { | ||
| var query = self | ||
| query.includesSubentities = value | ||
| return query | ||
| } | ||
|
|
||
| func count(in context: NSManagedObjectContext) -> Int { | ||
| (try? context.count(for: buildFetchRequest())) ?? 0 | ||
|
There was a problem hiding this comment. It'll be a bit more work, but let's not eat the error here – we should pass it up to the caller to deal with (for now we can have the same implementation at a higher level, but there's a difference between "there are no cells" and "there was an error trying to fetch the data", and the higher we can propagate that error, the more likely we can help the user understand what's going on) |
||
| } | ||
|
|
||
| func first(in context: NSManagedObjectContext) throws -> Result? { | ||
| let request = buildFetchRequest() | ||
| request.fetchLimit = 1 | ||
| return (try context.fetch(request).first) | ||
| } | ||
|
|
||
| func result(in context: NSManagedObjectContext) throws -> [Result] { | ||
| try context.fetch(buildFetchRequest()) | ||
| } | ||
|
|
||
| private func buildFetchRequest() -> NSFetchRequest<Result> { | ||
| let request = NSFetchRequest<Result>(entityName: Result.entityName()) | ||
| request.includesSubentities = includesSubentities | ||
| request.sortDescriptors = sortDescriptors | ||
| request.predicate = NSCompoundPredicate(andPredicateWithSubpredicates: predicates) | ||
| return request | ||
| } | ||
|
|
||
| func and(_ predicate: NSPredicate) -> Self { | ||
| var query = self | ||
| query.predicates.append(predicate) | ||
| return query | ||
| } | ||
| } | ||
|
|
||
| extension CoreDataQuery { | ||
| private func compare<Value>(_ keyPath: KeyPath<Result, Value>, type: NSComparisonPredicate.Operator, _ value: Value?, options: NSComparisonPredicate.Options = []) -> Self { | ||
| and( | ||
| NSComparisonPredicate( | ||
| leftExpression: NSExpression(forKeyPath: keyPath), | ||
| rightExpression: NSExpression(forConstantValue: value), | ||
| modifier: .direct, | ||
| type: type, | ||
| options: options | ||
| ) | ||
| ) | ||
| } | ||
|
|
||
| func contains<Value>(_ keyPath: KeyPath<Result, Value>, _ value: Value) -> Self { | ||
| compare(keyPath, type: .contains, value) | ||
| } | ||
|
|
||
| func equal<Value>(_ keyPath: KeyPath<Result, Value>, _ value: Value) -> Self { | ||
| compare(keyPath, type: .equalTo, value) | ||
| } | ||
|
|
||
| func null<Value>(_ keyPath: KeyPath<Result, Value>) -> Self { | ||
| compare(keyPath, type: .equalTo, nil) | ||
| } | ||
|
|
||
| func notNull<Value>(_ keyPath: KeyPath<Result, Value>) -> Self { | ||
| compare(keyPath, type: .notEqualTo, nil) | ||
| } | ||
|
|
||
| func order<Value>(by keyPath: KeyPath<Result, Value>, ascending: Bool = true) -> Self { | ||
| let property = NSExpression(forKeyPath: keyPath).keyPath | ||
| return ascending ? self.ascending(by: property) : self.descending(by: property) | ||
| } | ||
| } | ||
|
|
||
| protocol CoreDataQueryable { | ||
| associatedtype CoreDataQueryResult: NSManagedObject | ||
|
|
||
| static func query() -> CoreDataQuery<CoreDataQueryResult> | ||
| } | ||
|
|
||
| extension NSManagedObject: CoreDataQueryable {} | ||
|
|
||
| extension CoreDataQueryable where Self: NSManagedObject { | ||
| static func query() -> CoreDataQuery<Self> { | ||
| return CoreDataQuery<Self>() | ||
| } | ||
| } | ||
|
|
||
| extension CoreDataQuery where Result == Blog { | ||
|
|
||
| static func `default`() -> CoreDataQuery<Blog> { | ||
| Blog.query().order(by: \.settings?.name).includesSubentities(false) | ||
| } | ||
|
|
||
| func blogID(_ id: Int) -> Self { | ||
| blogID(id as NSNumber) | ||
| } | ||
|
|
||
| func blogID(_ id: NSNumber) -> Self { | ||
| equal(\.blogID, id) | ||
| } | ||
|
|
||
| func blogID(_ id: Int64) -> Self { | ||
| blogID(id as NSNumber) | ||
| } | ||
|
|
||
| func username(_ username: String) -> Self { | ||
| equal(\.account?.username, username) | ||
| } | ||
|
|
||
| func hostname(containing hostname: String) -> Self { | ||
| contains(\.url, hostname) | ||
| } | ||
|
|
||
| func hostname(matching hostname: String) -> Self { | ||
| equal(\.url, hostname) | ||
| } | ||
|
|
||
| func visible(_ flag: Bool) -> Self { | ||
| equal(\.visible, flag) | ||
| } | ||
|
|
||
| func hostedByWPCom(_ flag: Bool) -> Self { | ||
| flag ? notNull(\.account) : null(\.account) | ||
| } | ||
|
|
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
Resulthere is confusing to me because of theResult<T, Error>type. WDYT?