Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Detail Redesign: Implement trash & delete #19358

Merged

Conversation

alpavanoglu
Copy link
Contributor

Fixes #18999

This is the final PR to be merged on the feature branch. After this one, we should test the feature branch all together and update the Release Notes.

To test:

  1. Log in to a WP Account
  2. In My Site, select Menu
  3. Comments
  4. Select any comment
  5. Tap on trash/delete button.
  6. Validate if trash moves the comment.
  7. Tap on one of the status options (Approve/Pending/Spam) to see if button updates from Delete to Trash again.
  8. Verify if Delete permanently deletes the comment.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@alpavanoglu
Copy link
Contributor Author

I have removed SingleButtonTableViewCell.swift as I've found it is not being used in the codebase. It is not related to my changes but since it is just a deletion, it wouldn't need any testing or reviewing.

@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19358-838cfdd on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19358-838cfdd on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@wargcm wargcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@alpavanoglu alpavanoglu merged commit ff3adb3 into task/comment-detail-redesign Sep 29, 2022
@alpavanoglu alpavanoglu deleted the task/comment-detail-redesign-trash branch September 29, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants