Comment Detail Redesign: Moderation Bar Update #19331
Conversation
| updateModerationBarVisibility() | ||
| } | ||
| } | ||
| // var hidesModerationBar: Bool = false { |
There was a problem hiding this comment.
Commented out snippets are addressed and will be included in next PR's.
| case .content: | ||
| return nil | ||
| case .moderation: | ||
| return "STATUS" |
There was a problem hiding this comment.
This is localized and will be updated in next PR's.
You can test the changes in Jetpack from this Pull Request by:
|
You can test the changes in WordPress from this Pull Request by:
|
| spamComment() | ||
| case .unapproved: | ||
| trashComment() | ||
| return NSLocalizedString("Spam", comment: "Button title for Spam comment state.") |
There was a problem hiding this comment.
I thought there was a P2 somewhere saying we needed to start adding keys to localized strings but all I could find was paNNhX-nP-p2. It doesn't say we need keys, just that the option is there.
Regardless, I don't think it's a huge deal since I can't find the post anywhere. Just wanted to point it out in case you happen to know more.
There was a problem hiding this comment.
Oh no I saw that as well and have been doing it. These are existing strings but I can do it regardless
|
@wargcm That blinking issue is resolved in my local branch but I added a condition to not allow a selected status to be selected regardless. So it should fix it here as well. |
Fixes #18999
This PR removes the old moderation bar from comments section and adds a new table-view version of it.
To test:
Regression Notes
Potential unintended areas of impact
Comments' status may not function properly
What I did to test those areas of impact (or what existing automated tests I relied on)
Manually tested it. Follow the steps above.,
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.