-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix push prompt button overlapping on iPad #19304
Fix push prompt button overlapping on iPad #19304
Conversation
c7bf9c7
to
420fca0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @ipalm0423 - would you mind catching this branch up with the latest on trunk
? Typically this wouldn't be required without a merge conflict, but we just merged Xcode 14 support and it won't build in that environment until we have those changes.
Thanks!
420fca0
to
2a4789e
Compare
@twstokes 👋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM @ipalm0423 - I just had one question in the review.
Thanks for including a clear description, screenshots, and testing steps. It makes sense that this fix wouldn't easily be unit-testable as it's changes to the UI.
Should step 8 of the testing steps be updated to reflect the expectations?
.../Classes/ViewRelated/Blog/Blogging Reminders/BloggingRemindersPushPromptViewController.swift
Outdated
Show resolved
Hide resolved
I've pushed up a branch to run CI since it's a requirement before we can merge. #19332 |
Thank you for reviewing!
Agree, It is not easy for unit test. The view is independent, so manual testing could fully cover the change.
Modified. Thanks for reminding me😄. |
2a4789e
to
105308f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @ipalm0423! I've pushed up the latest to the CI branch to run tests. Once those are successful we'll merge. 👍
Fixes #19243
Description:
This PR fix the issue where the bottom button was overlapping with other labels on the view.
Root Cause:
The constraints setup is wrong on BloggingRemindersPushPromptViewController.configureConstraints.
The
turnOnNotificationsButton
should below the labelsstackView
, so the constants should use a negative value not positive-Metrics.edgeMargins.bottom
Fix:
Test Step:
Regression Notes
n/a
PR submission checklist:
RELEASE-NOTES.txt
if necessary.