Set Parent from Page Settings screen #19021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ParentPageSettingsViewController can either have a "Cancel" button or "Back" button. - ParentPageSettingsViewController can be configured to set page.parentID locally or remotely. - ParentPageSettingsViewController cna be dismissed automatically when the user selects a page parent.
salimbraksa
commented
Jul 9, 2022
|
|
||
| /// Provides an API to access the current parent of a page, and list of parent pages available for editing. | ||
| /// | ||
| @objc class ParentPagesController: NSObject { |
There was a problem hiding this comment.
I needed a way to access the parent pages that can be selected for a child page. So that I display them later in "Set Page" screen.
The good news is that this logic is already implemented in PageListTableViewHandler. The bad news is that the class is tightly coupled with PageListViewController's table view. So I couldn't re-use that class elsewhere.
The solution was to read PageListTableViewHandler and extract only the code that fetches a page's parents available for editing. Then put that logic in a new class that I called ParentPagesController. This class doesn't depend on any view and be used anywhere.
You can see how this class is used in PageSettingsViewController.
Let me know what you think. 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Closes #13150
Testing Instructions
TBD
Screen Recordings
Regression Notes
Potential unintended areas of impact
TBD
What I did to test those areas of impact (or what existing automated tests I relied on)
TBD
What automated tests I added (or what prevented me from doing so)
TBD
PR submission checklist:
RELEASE-NOTES.txtif necessary.