Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move lint translations and RuboCop in a group step in Buildkite #19000

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Move lint translations and RuboCop in a group step in Buildkite #19000

merged 1 commit into from
Jul 7, 2022

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Jul 7, 2022 •
edited
Loading

💅

image

image

image

If CI is green, we can merge this.

Regression Notes

  1. Potential unintended areas of impact – N.A.
  2. What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
  3. What automated tests I added (or what prevented me from doing so) – N.A.
  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes. N.A.
  • I have considered adding accessibility improvements for my changes. N.A.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

@mokagio mokagio added this to the 20.3 milestone Jul 7, 2022
@mokagio mokagio added [Type] Enhancement Tooling Build, Release, and Validation Tools labels Jul 7, 2022
@mokagio mokagio marked this pull request as ready for review July 7, 2022 01:58
@mokagio mokagio enabled auto-merge July 7, 2022 01:59
@mokagio mokagio requested a review from a team July 7, 2022 01:59
@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19000-3a0bce4 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19000-3a0bce4 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@mokagio mokagio requested a review from tiagomar July 7, 2022 05:16
@mokagio mokagio merged commit dac7d79 into trunk Jul 7, 2022
@mokagio mokagio deleted the group-linters branch July 7, 2022 15:32
AliSoftware
AliSoftware reviewed Jul 7, 2022
View reviewed changes
.buildkite/pipeline.yml
command: .buildkite/commands/rubocop-via-danger.sh
env: *common_env
plugins: *common_plugins
- group: " Linters"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why the extra space? 🙃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahah. Must be a leftover from me trying to add an emoji or something... 🤔

Luckily Buildkite trims it in the UI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy fix... #19008

mokagio added a commit that referenced this pull request Jul 7, 2022
@mokagio
Remove a leading space that sunk in the Buildkite "Linter" group label
8a5a35c 
See
#19000 (comment)
@mokagio mokagio mentioned this pull request Jul 7, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliSoftware AliSoftware AliSoftware left review comments

@oguzkocer oguzkocer oguzkocer approved these changes

@tiagomar tiagomar Awaiting requested review from tiagomar

Assignees
No one assigned
Labels
Tooling Build, Release, and Validation Tools [Type] Enhancement
Projects
None yet
Milestone
20.3
Development

Successfully merging this pull request may close these issues.
4 participants
@mokagio @wpmobilebot @AliSoftware @oguzkocer