Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Start: don’t display quick start prompt for self-hosted sites #18608

Merged
merged 1 commit into from
May 16, 2022

Conversation

momo-ozawa
Copy link
Contributor

Fixes #18547
Fixes #18458

Description

  • Quick Start (and the prompt) shouldn't be displayed for self-hosted sites.

How to test

  1. Add a self-hosted site
  2. ✅ Verify: the quick start prompt is NOT displayed
Simulator.Screen.Recording.-.iPhone.13.-.2022-05-13.at.16.10.32.mp4

Regression Notes

  1. Potential unintended areas of impact
  • Self-hosted login
  1. What I did to test those areas of impact (or what existing automated tests I relied on)
  • Tested manually
  1. What automated tests I added (or what prevented me from doing so)
  • N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18608-fde722a on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18608-fde722a on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@hassaanelgarem hassaanelgarem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described 🚀

@momo-ozawa momo-ozawa merged commit 8d5987d into trunk May 16, 2022
@momo-ozawa momo-ozawa deleted the task/18547-disable-qs-for-self-hosted branch May 16, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants