Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation buttons not scaling with large fonts in Site Intent #18559

Merged
merged 2 commits into from
May 11, 2022

Conversation

Gio2018
Copy link
Contributor

@Gio2018 Gio2018 commented May 10, 2022

Fixes #18230

To test:

  • Checkout this branch
  • Enable site name, in order to test the full navigation: this can be done by overriding
private var shouldShowSiteName: Bool {
        return nameVariant == .treatment(nil) && FeatureFlag.siteName.enabled
}

in SiteCreationWizardLauncher and temporarily set it to true

  • Build/run and start the site creation flow
  • make sure the appearance of the navigation bar and button looks correct in all the navigation steps
  • Go to the device settings and change the font size in Accessibility
  • Restart the site creation flow, and verify that the Cancel and Skip buttons scale correctly
  • Check that the navigation bar looks correct in the rest of the flow

Regression Notes

  1. Potential unintended areas of impact
    Low, this change only affects the appearance of the navigation bar in the site creation flow.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Test the entire site creation flow

  3. What automated tests I added (or what prevented me from doing so)
    none
    PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Gio2018 Gio2018 added this to the 19.9 milestone May 10, 2022
@Gio2018 Gio2018 self-assigned this May 10, 2022
@Gio2018 Gio2018 requested a review from twstokes May 10, 2022 21:29
@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18559-63bb2db on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18559-63bb2db on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @Gio2018! 🚀

@Gio2018 Gio2018 merged commit 872a98b into trunk May 11, 2022
@Gio2018 Gio2018 deleted the issue/18230-site-intent-navigation-buttons-not-scaling branch May 11, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bar buttons text does not properly scale in the default verticals screen
3 participants