[Site Design Revamp] Main View - Remove the filter bar

[twstokes]

• Item D subtask of [Site Design Revamp] Main View Updates #18433

For the Site Design Screen Improvements project it's been decided to remove the filter bar from the Site Design screen. Filtering may be reintroduced in the future.

Before

Portrait	Landscape

After

Portrait	Landscape

Observations:

1. The gray separator no longer appears between the title and the collection. This may be OK as it matches the design for this project.
2. Extra spacing between the title and the collection. We should consider tightening the design after or while implementing [Site Design Revamp] Main View - Add recommended designs section #18434.
3. In landscape the collapsed title isn't shown in the nav bar. This is a known issue.

Change	Design

Testing

No filter bar

1. Start the Site Creation flow
2. On the Design Screen, expect that there is no filter bar at the top
3. Tapping a design allows the user to preview it
4. Choosing a design and finishing the site creation flow succeeds

Page creation isn't affected

1. From the My Site view, tap the FAB button (blue circle at the bottom right)
2. Tap "Site page"
3. Observe the filter bar
4. Tap a category on the filter bar and expect the page designs to be filtered

Regression Notes

1. Potential unintended areas of impact

   • Other views that use the FilterableCategoriesViewController
     • Currently just the page design picker
   • Site Design screen functionality

2. What I did to test those areas of impact (or what existing automated tests I relied on)

   • The manual tests above

3. What automated tests I added (or what prevented me from doing so)

   • None, as this is UI code.

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

You can test the changes in Jetpack from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr18501-8386bd2 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[wpmobilebot]

You can test the changes in WordPress from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr18501-8386bd2 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[twstokes]

Moving this back to Draft status as it'll most likely be scrapped in favor of a new subclass.

[twstokes]

Superseded by #18506.