Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick Start for Existing Users: Respect feature flag when logging into a self-hosted site #18457

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Quick Start for Existing Users: Respect feature flag when logging into a self-hosted site #18457

merged 1 commit into from
Apr 27, 2022

Conversation

hassaanelgarem
Copy link
Contributor

@hassaanelgarem hassaanelgarem commented Apr 26, 2022 •
edited by momo-ozawa
Loading

Part of #18388

Description

  • We decided to show the new tour after signing into a self-hosted site. (Ref: p1650894845585159/1650522675.714159-slack-C027K4MNPGQ)
  • This was added in f1a81ad but I forgot to account for the feature flag.
  • This PR hides this new logic behind the quickStartForExistingUsers feature flag

Testing Instructions

Self Hosted with Feature Flag enabled

  1. Install the app
  2. Logout if needed
  3. Login into a self hosted site
  4. Tap "Show me around"
  5. Make sure that the new set of tasks is displayed in the quick start card

Self Hosted with Feature Flag disabled

  1. Manually disable feature flag from code
  2. Install the app
  3. Logout if needed
  4. Login into a self hosted site
  5. Tap "Show me around"
  6. Make sure that the old set of tasks is displayed in the quick start card

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hassaanelgarem
Fix: tour assignment for self-hosted sites
dea1064 
Only assign new tours if the feature flag is enabled
@hassaanelgarem hassaanelgarem added this to the 19.8 milestone Apr 26, 2022
@hassaanelgarem hassaanelgarem self-assigned this Apr 26, 2022
@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18457-dea1064 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18457-dea1064 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

momo-ozawa
momo-ozawa approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hassaanelgarem hassaanelgarem merged commit da25f3e into trunk Apr 27, 2022
@hassaanelgarem hassaanelgarem deleted the fix/18388-wrong-tour-for-self-hosted branch April 27, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momo-ozawa momo-ozawa momo-ozawa approved these changes

Assignees

@hassaanelgarem hassaanelgarem

Labels
[Type] Bug
Projects
None yet
Milestone
19.8
Development

Successfully merging this pull request may close these issues.
3 participants
@hassaanelgarem @wpmobilebot @momo-ozawa