-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blogging Prompts Feature Introduction: allow prompt card size to be dynamic #18454
Conversation
Hey @iamthomasbishop . I know when we DM'ed about the size of the card, you referred to it being regular card component just scaled down to like 80% or something. However, the card isn't a static size so that wasn't exactly possible. So in this context I made it 75% of the screen width, which may be about the same. But let me know what you think. Thanks! |
You can test the changes in Jetpack from this Pull Request by:
|
You can test the changes in WordPress from this Pull Request by:
|
@ScoutHarris That looks great, thank you! 👍 |
@ScoutHarris Just to confirm, when you say "75% of the screen width" does that apply to iPad as well? |
Hey @iamthomasbishop .
Yea it does. Sorry, I meant to ask about iPad. I wasn't sure what it was supposed to look like there, so it is the same regardless. If you'd prefer something else, just let me know. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one minor comment. Otherwise, changes are looking good (code-wise).
WordPress/Classes/ViewRelated/Blog/Blog Dashboard/Cards/Prompts/DashboardPromptsCardCell.swift
Outdated
Show resolved
Hide resolved
…s/DashboardPromptsCardCell.swift Set var to read-only. Co-authored-by: David Christiandy <[email protected]>
Ref: #18176
The prompt card width and height are now dynamic.
To test:
bloggingPrompts
feature flag.CollapsableHeaderViewController
.Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.