Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blogging Prompts Feature Introduction: allow prompt card size to be dynamic #18454

Merged
merged 5 commits into from
Apr 28, 2022

Conversation

ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Apr 26, 2022

Ref: #18176

The prompt card width and height are now dynamic.

  • The width is 75% of the screen width.
  • The height is determined by the card's layout.

To test:

  • Enable bloggingPrompts feature flag.
  • When the app launches, the Feature Introduction appears.
  • Verify the example prompt card is not as wide as it was previously.
  • Change the text size.
  • Verify the example prompt card height changes dynamically.
  • NOTE: The header view doesn't resize correctly. This is a separate issue with the CollapsableHeaderViewController.
Before After
before_iphone after_iphone
before_ipad after_ipad

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ScoutHarris ScoutHarris added this to the 19.8 milestone Apr 26, 2022
@ScoutHarris ScoutHarris self-assigned this Apr 26, 2022
@ScoutHarris ScoutHarris added the [Status] Needs Design Review A designer needs to sign off on the implemented design. label Apr 26, 2022
@ScoutHarris ScoutHarris marked this pull request as ready for review April 26, 2022 20:54
@ScoutHarris
Copy link
Contributor Author

Hey @iamthomasbishop .

I know when we DM'ed about the size of the card, you referred to it being regular card component just scaled down to like 80% or something. However, the card isn't a static size so that wasn't exactly possible. So in this context I made it 75% of the screen width, which may be about the same. But let me know what you think. Thanks!

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 26, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18454-0a30b78 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 26, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18454-0a30b78 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@iamthomasbishop
Copy link

@ScoutHarris That looks great, thank you! 👍

@iamthomasbishop
Copy link

iamthomasbishop commented Apr 27, 2022

@ScoutHarris Just to confirm, when you say "75% of the screen width" does that apply to iPad as well?

@ScoutHarris
Copy link
Contributor Author

Hey @iamthomasbishop .

when you say "75% of the screen width" does that apply to iPad as well?

Yea it does. Sorry, I meant to ask about iPad. I wasn't sure what it was supposed to look like there, so it is the same regardless. If you'd prefer something else, just let me know. Thanks!

Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor comment. Otherwise, changes are looking good (code-wise). :shipit:

ScoutHarris and others added 2 commits April 27, 2022 12:21
…s/DashboardPromptsCardCell.swift


Set var to read-only.

Co-authored-by: David Christiandy <[email protected]>
@ScoutHarris ScoutHarris removed the [Status] Needs Design Review A designer needs to sign off on the implemented design. label Apr 28, 2022
@ScoutHarris ScoutHarris merged commit 5ef12d7 into trunk Apr 28, 2022
@ScoutHarris ScoutHarris deleted the feature/18176-prompt_card_size branch April 28, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants