Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.7] Update release note for #18127 #18401

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

twstokes
Copy link
Contributor

This PR updates the release note for the changes submitted by an external contributor in #18127.

Originally the issue seemed limited to Reader, but the final fix affected multiple areas of the app that render web previews.

@twstokes twstokes added this to the 19.7 ❄️ milestone Apr 19, 2022
@twstokes twstokes requested a review from a team April 19, 2022 20:06
@twstokes twstokes self-assigned this Apr 19, 2022
@twstokes twstokes changed the base branch from trunk to release/19.7 April 19, 2022 20:07
@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below
  • Then installing the build number pr18401-62018c4 from App Center on your iPhone

The .ipa file can also be downloaded directly here.
If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below
  • Then installing the build number pr18401-62018c4 from App Center on your iPhone

The .ipa file can also be downloaded directly here.
If you need access to App Center, please ask a maintainer to add you.

@twstokes twstokes removed the Releases label Apr 19, 2022
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is missing at least one label.
⚠️

This PR contains changes to RELEASE_NOTES.txt.
Note that these changes won't affect the final version of the release notes as this version is in code freeze.
Please, get in touch with a release manager if you want to update the final release notes.

Generated by 🚫 dangerJS

@twstokes
Copy link
Contributor Author

👋 @mokagio - I helped with this external contribution and didn't think to tweak the release notes until now. Could you let me know if this will be a big problem and how we should proceed? Apologies for throwing a 🔧 in things.

Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mokagio
Copy link
Contributor

mokagio commented Apr 20, 2022

@twstokes

👋 @mokagio - I helped with this external contribution and didn't think to tweak the release notes until now. Could you let me know if this will be a big problem and how we should proceed? Apologies for throwing a 🔧 in things.

No worries at all. I'll merge the PR now and make sure the notes including this tweak reach our copy writer. Easy peasy.

@mokagio mokagio merged commit ed4a7a1 into release/19.7 Apr 20, 2022
@mokagio mokagio deleted the task/previews-safe-area-release-note branch April 20, 2022 02:53
mokagio added a commit that referenced this pull request Apr 20, 2022
I had forgotten about this when approving then merging the PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants