[Site Name] Adjusts design picker buttons for treatment variation #18397

antonis · 2022-04-19T09:41:57Z

Description

This PR adjusts the design picker Choose buttons to communicate to the user that their action will create the site.

Design Chooser(Control)	Design Chooser(Treatment)

Design Preview(Control)	Design Preview(Treatment)

To test

Treatment variation

Toggle ON the Site Name feature
Start the Site Creation flow
Choose an intent for your site or skip
Enter a site name or skip
Select a design
Verify that the choose button is changed to create site
Preview a design and verify that the choose button is changed to create site

Control variation

Toggle OFF the Site Name feature
On steps 6 and 7 above verify that the buttons are not changed

Regression Notes

Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A

PR submission checklist:

I have completed the Regression Notes.
I have considered adding unit tests for my changes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

wpmobilebot · 2022-04-19T10:08:17Z

You can test the changes in Jetpack from this Pull Request by:

Clicking here or scanning the QR code below
Then installing the build number pr18397-fc7ddd3 from App Center on your iPhone

The .ipa file can also be downloaded directly here.
If you need access to App Center, please ask a maintainer to add you.

wpmobilebot · 2022-04-19T10:09:34Z

You can test the changes in WordPress from this Pull Request by:

Clicking here or scanning the QR code below
Then installing the build number pr18397-fc7ddd3 from App Center on your iPhone

The .ipa file can also be downloaded directly here.
If you need access to App Center, please ask a maintainer to add you.

antonis · 2022-04-19T10:31:32Z

Note: The PR will probably need to target release/19.7

…eation step

…ion step

antonis · 2022-04-19T13:59:55Z

The skip button change was reverted with 7a4701d

Gio2018

Thanks for tackling this @antonis ! the change works as expected; just left a couple of comments for you to consider.

Gio2018 · 2022-04-19T17:23:34Z

...asses/ViewRelated/Site Creation/Design Selection/Preview/TemplatePreviewViewController.swift

@@ -100,10 +100,13 @@ class TemplatePreviewViewController: UIViewController, NoResultsViewHost, UIPopo
    }

    private func styleButtons() {
+        let isLastSiteCreationStep = ABTest.siteNameV1.variation == .treatment(nil) && FeatureFlag.siteName.enabled
+        let mainButtonTitle = isLastSiteCreationStep ? NSLocalizedString("Create site", comment: "Title for the button to progress with creating the site with the selected design")


since we have a couple of hardcoded strings, including this one, would it be possible to group them in a private enum?

Great suggestion @Gio2018 👍
Handled with babc542

Gio2018 · 2022-04-19T17:23:55Z

...asses/ViewRelated/Site Creation/Design Selection/Preview/TemplatePreviewViewController.swift

@@ -100,10 +100,13 @@ class TemplatePreviewViewController: UIViewController, NoResultsViewHost, UIPopo
    }

    private func styleButtons() {
+        let isLastSiteCreationStep = ABTest.siteNameV1.variation == .treatment(nil) && FeatureFlag.siteName.enabled
+        let mainButtonTitle = isLastSiteCreationStep ? NSLocalizedString("Create site", comment: "Title for the button to progress with creating the site with the selected design")
+            : NSLocalizedString("Choose", comment: "Title for the button to progress with the selected site homepage design")


nit: the comment should have a period at the end.

Handled with babc542 👍

Gio2018 · 2022-04-19T17:24:44Z

...s/ViewRelated/Site Creation/Design Selection/SiteDesignContentCollectionViewController.swift


        super.init(
            analyticsLocation: "site_creation",
            mainTitle: NSLocalizedString("Choose a design", comment: "Title for the screen to pick a design and homepage for a site."),
            prompt: NSLocalizedString("Pick your favorite homepage layout. You can edit and customize it later.", comment: "Prompt for the screen to pick a design and homepage for a site."),
-            primaryActionTitle: NSLocalizedString("Choose", comment: "Title for the button to progress with the selected site homepage design"),


similar comments here: the comment should have a period, and since this file has quite a few hardcoded strings, wondering if we can group them?

As above handled with babc542. Thank you for the feedback 🙇

twstokes · 2022-04-19T17:54:08Z

👋 If we're going to land on a single string after the A/B tests I'd suggest not using this PR to keep things simpler, but I've created one with tests in case we might need it.

[Site Creation] Pass a boolean to determine Site Design primary button titles #18400

twstokes

My only suggestion would be to consider making changes in SiteDesignPreviewViewController rather than TemplatePreviewViewController since it's a more specific subclass. LayoutPreviewViewController also relies on TemplatePreviewViewController but because of ordering it isn't affected. 👍

…ign-buttons-tweaks [Site Creation] Pass a boolean to determine Site Design primary button titles

antonis · 2022-04-20T12:02:25Z

👋 If we're going to land on a single string after the A/B tests I'd suggest not using this PR to keep things simpler, but I've created one with tests in case we might need it.

[Site Creation] Pass a boolean to determine Site Design primary button titles #18400

Thank you for your suggestions @twstokes 🙇
I agree that your approach is a lot cleaner (can be unit tested 🎉 ) and might also be useful in our future enhancements (even when we remove the experiment). I've merged your draft PR onto this one :)

…screen button

peril-wordpress-mobile · 2022-04-20T13:12:04Z

	Warnings
⚠️	This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

antonis · 2022-04-20T14:02:59Z

⚠️ Please check the response here (internal ref: p5T066-37N-p2#comment-12065) before merging to the frozen 19.7 release 🙇

ovitrif

All good during testing (both with Site Name on / off) and the way the "shape" of the code improved is quite nice! 🚀

Thank you @antonis & @twstokes for your collaborative efforts on this, and @Gio2018 for the valuable feedback 🙇.

I'm approving the PR, but as per the PR merge policy for our iOS repos, the author would normally merge it.

Apparently we're still in need of a follow-up to this internal comment: p5T066-37N-p2#comment-12066

twstokes

LGTM! 🙇 If I understand correctly about how the translation keys work, the interface should translate "Create Site" because that key has been translated before and the comment isn't part of the key.

twstokes · 2022-04-20T14:23:06Z

...ses/ViewRelated/Site Creation/Design Selection/Preview/SiteDesignPreviewViewController.swift

+        primaryActionButton.setTitle(createsSite ? TextContent.createSiteButton : TextContent.chooseButton, for: .normal)
+    }
+
+    private enum TextContent {


Nice, good suggestion @Gio2018 and implementation @antonis. Makes things a lot cleaner!

Gio2018

Awesome @antonis ! !

mokagio · 2022-04-21T04:19:55Z

@antonis and @twstokes (writing a single comment in the main PR) this has been bundled as part of 19.7 beta 1 (19.7.0.1).

Thanks for your work 🙌

antonis added [Type] Task Site Creation labels Apr 19, 2022

antonis added this to the 19.7 ❄️ milestone Apr 19, 2022

antonis requested review from kyleaparker and a team April 19, 2022 09:45

antonis added 4 commits April 19, 2022 16:56

Changes design selection action buttons when this is the last site cr…

d9fbe30

…eation step

Changes design preview action button when this is the last site creat…

4c0a984

…ion step

Removes trailing spaces

082306a

Reverts change for the skip button

7a4701d

antonis force-pushed the feature/site-name-design-buttons branch from a1a9b91 to 7a4701d Compare April 19, 2022 13:57

antonis changed the base branch from trunk to release/19.7 April 19, 2022 13:57

antonis marked this pull request as ready for review April 19, 2022 15:34

Pass a boolean to determine if the Site Design step is the last one.

9ecd2b8

Gio2018 reviewed Apr 19, 2022

View reviewed changes

Add tests.

e2f575c

twstokes reviewed Apr 19, 2022

View reviewed changes

antonis added 2 commits April 20, 2022 14:54

Groups string resources

babc542

Merge pull request #18400 from wordpress-mobile/feature/site-name-des…

7ad2a9d

…ign-buttons-tweaks [Site Creation] Pass a boolean to determine Site Design primary button titles

antonis requested review from Gio2018 and twstokes April 20, 2022 12:48

antonis added 2 commits April 20, 2022 16:03

Adds all the controller resources in the group

00accc5

Changed create site button title capitalisation to match the domains …

fc7ddd3

…screen button

ovitrif approved these changes Apr 20, 2022

View reviewed changes

kyleaparker approved these changes Apr 20, 2022

View reviewed changes

twstokes approved these changes Apr 20, 2022

View reviewed changes

Gio2018 approved these changes Apr 20, 2022

View reviewed changes

mokagio merged commit a7c675f into release/19.7 Apr 21, 2022

mokagio deleted the feature/site-name-design-buttons branch April 21, 2022 01:56

mokagio mentioned this pull request Apr 21, 2022

Merge changes from beta 19.7.0.1 + Release Notes #18411

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Site Name] Adjusts design picker buttons for treatment variation #18397

[Site Name] Adjusts design picker buttons for treatment variation #18397

antonis commented Apr 19, 2022 •

edited

Loading

wpmobilebot commented Apr 19, 2022 •

edited

Loading

wpmobilebot commented Apr 19, 2022 •

edited

Loading

antonis commented Apr 19, 2022

antonis commented Apr 19, 2022

Gio2018 left a comment

Gio2018 Apr 19, 2022

antonis Apr 20, 2022

Gio2018 Apr 19, 2022

antonis Apr 20, 2022

Gio2018 Apr 19, 2022

antonis Apr 20, 2022

twstokes commented Apr 19, 2022

twstokes left a comment

antonis commented Apr 20, 2022 •

edited

Loading

peril-wordpress-mobile bot commented Apr 20, 2022

antonis commented Apr 20, 2022

ovitrif left a comment

twstokes left a comment

twstokes Apr 20, 2022

Gio2018 left a comment

mokagio commented Apr 21, 2022

[Site Name] Adjusts design picker buttons for treatment variation #18397

[Site Name] Adjusts design picker buttons for treatment variation #18397

Conversation

antonis commented Apr 19, 2022 • edited Loading

Description

To test

Treatment variation

Control variation

Regression Notes

wpmobilebot commented Apr 19, 2022 • edited Loading

wpmobilebot commented Apr 19, 2022 • edited Loading

antonis commented Apr 19, 2022

antonis commented Apr 19, 2022

Gio2018 left a comment

Choose a reason for hiding this comment

Gio2018 Apr 19, 2022

Choose a reason for hiding this comment

antonis Apr 20, 2022

Choose a reason for hiding this comment

Gio2018 Apr 19, 2022

Choose a reason for hiding this comment

antonis Apr 20, 2022

Choose a reason for hiding this comment

Gio2018 Apr 19, 2022

Choose a reason for hiding this comment

antonis Apr 20, 2022

Choose a reason for hiding this comment

twstokes commented Apr 19, 2022

twstokes left a comment

Choose a reason for hiding this comment

antonis commented Apr 20, 2022 • edited Loading

peril-wordpress-mobile bot commented Apr 20, 2022

antonis commented Apr 20, 2022

ovitrif left a comment

Choose a reason for hiding this comment

twstokes left a comment

Choose a reason for hiding this comment

twstokes Apr 20, 2022

Choose a reason for hiding this comment

Gio2018 left a comment

Choose a reason for hiding this comment

mokagio commented Apr 21, 2022

antonis commented Apr 19, 2022 •

edited

Loading

wpmobilebot commented Apr 19, 2022 •

edited

Loading

wpmobilebot commented Apr 19, 2022 •

edited

Loading

antonis commented Apr 20, 2022 •

edited

Loading