Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Site Name] Removes Site Intent Question A/B test #18367

Merged
merged 3 commits into from
Apr 15, 2022
Merged

[Site Name] Removes Site Intent Question A/B test #18367

merged 3 commits into from
Apr 15, 2022

Conversation

twstokes
Copy link
Contributor

@twstokes twstokes commented Apr 13, 2022 •
edited
Loading

Closes #18352

To test:

  1. Start the Site Creation flow
  2. Verify that the Site Intent Screen appears

Regression Notes

  1. Potential unintended areas of impact
  • Site Creation flow behavior for users in the Site Name treatment and control groups
  1. What I did to test those areas of impact (or what existing automated tests I relied on)
  • Manual testing, ran existing tests
  1. What automated tests I added (or what prevented me from doing so)
  • Updated existing tests

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@twstokes twstokes added this to the 19.7 milestone Apr 13, 2022
@twstokes twstokes self-assigned this Apr 13, 2022
@twstokes twstokes marked this pull request as ready for review April 13, 2022 21:37
@twstokes twstokes requested review from a team and Gio2018 April 13, 2022 21:37
@twstokes
Copy link
Contributor Author

👋 If we can, let's merge this after #18366 since it's based on it. 🙇

@twstokes twstokes changed the title [Site Name] Removes Site Intent Question A/B/ test [Site Name] Removes Site Intent Question A/B test Apr 13, 2022
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 13, 2022 •
edited
Loading

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below
  • Then installing the build number pr18367-e611c47 from App Center on your iPhone

The .ipa file can also be downloaded directly here.
If you need access to App Center, please ask a maintainer to add you.

Base automatically changed from task/site-name-tracks to trunk April 15, 2022 19:20
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below
  • Then installing the build number pr18367-e611c47 from App Center on your iPhone

The .ipa file can also be downloaded directly here.
If you need access to App Center, please ask a maintainer to add you.

Gio2018
Gio2018 approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@Gio2018 Gio2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@twstokes twstokes merged commit cf81248 into trunk Apr 15, 2022
@twstokes twstokes deleted the task/remove-site-intent-ab-test branch April 15, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gio2018 Gio2018 Gio2018 approved these changes

Assignees

@twstokes twstokes

Labels
Site Creation [Type] Task
Projects
No open projects
Site Intent Question Project
Status: Done
Milestone
19.7
Development

Successfully merging this pull request may close these issues.

[Site Name] Remove Site Intent Question A/B test
3 participants
@twstokes @wpmobilebot @Gio2018