Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blogging Prompts: Update prompt card lightbulb icon #18333

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

dvdchr
Copy link
Contributor

@dvdchr dvdchr commented Apr 8, 2022

Refs #18250
Depends on #18320

As titled, this updates the lightbulb icon from SFSymbols to icon-lightbulb-outline.

Before After
lightbulb_before lightbulb_after

To test

  • Turn on Blogging Prompts and My Site Dashboard feature flags.
  • Go to My Site Dashboard, Home tab.
  • Verify that the prompt card is displayed with the new lightbulb icon.

Regression Notes

  1. Potential unintended areas of impact
    N/A. Feature is under development.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A. Feature is under development.

  3. What automated tests I added (or what prevented me from doing so)
    N/A. Feature is under development.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below
  • Then installing the build number pr18333-3e45526 from App Center on your iPhone

The .ipa file can also be downloaded directly here.
If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below
  • Then installing the build number pr18333-3e45526 from App Center on your iPhone

The .ipa file can also be downloaded directly here.
If you need access to App Center, please ask a maintainer to add you.

Base automatically changed from feature/18176-lightbulb_icon to trunk April 8, 2022 19:17
Copy link
Contributor

@ScoutHarris ScoutHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 🪄 .

:shipit:

@ScoutHarris ScoutHarris merged commit 7890e07 into trunk Apr 8, 2022
@ScoutHarris ScoutHarris deleted the feature/18250-card-lightbulb-icon branch April 8, 2022 19:57
@dvdchr dvdchr linked an issue Apr 11, 2022 that may be closed by this pull request
7 tasks
@dvdchr dvdchr removed a link to an issue Apr 12, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants