Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Site Dashboard: keep collection view position after an update #18245

Merged

Conversation

leandroalonso
Copy link
Contributor

Fixes #18195

This PR is somewhat a workaround around the collection view scrolling to the top after an update. In order to properly fix we'll need to review the way we display posts cards.

However, it does offer a better experience. :)

Simulator.Screen.Recording.-.iPhone.13.-.2022-03-30.at.14.45.55.mp4

To test

  1. Run the app
  2. Go to a site with Quick Start enabled and a few draft posts (enough content to scroll down as the video above)
  3. Create a scheduled post
  4. Check that the dashboard update but the position is the same

Regression Notes

  1. Potential unintended areas of impact
    iPad

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    I manually tested on iPad.

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below
  • Then installing the build number pr18245-4d64eb9 from App Center on your iPhone

The .ipa file can also be downloaded directly here.
If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below
  • Then installing the build number pr18245-4d64eb9 from App Center on your iPhone

The .ipa file can also be downloaded directly here.
If you need access to App Center, please ask a maintainer to add you.

Base automatically changed from task/enable_my_site_dashboard to trunk March 31, 2022 12:59
@leandroalonso leandroalonso merged commit dde7abc into trunk Mar 31, 2022
@leandroalonso leandroalonso deleted the issue/18195_keep_collection_view_position_after_update branch March 31, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

My Site Dashboard: the update of the collection view resets the screen position
3 participants