Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log messages that could crash the app due to missing params. #18191

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Mar 23, 2022

Ref: #18129

In this change, I added some "nice to have" log messages. Turns out, they weren't so nice to have as some of the data could be missing, causing the app to crash.

  • I removed two logs I added that are unrelated to the feature, but seemed like a good idea at the time.
  • The log that is related to the feature and I want to keep, I removed possible empty values.

To test:

  • Go to Reader > Automattic tab.
  • Select a cross-post post where the original post is on a P2 where you are not a member.
    • If running in a simulator, disabling the proxy should result in the same behavior.
  • Verify the app does not crash, and the Error Loading Post view is shown.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ScoutHarris ScoutHarris added this to the 19.5 ❄️ milestone Mar 23, 2022
@ScoutHarris ScoutHarris self-assigned this Mar 23, 2022
@ScoutHarris ScoutHarris marked this pull request as ready for review March 23, 2022 18:50
@ScoutHarris
Copy link
Contributor Author

Hey @mokagio . This will need to go in the next 19.5 release. Thank you!

@ScoutHarris ScoutHarris requested a review from guarani March 23, 2022 19:05
@wpmobilebot
Copy link
Contributor

You can test the Jetpack changes on this Pull Request by downloading it from AppCenter here with build number: pr18191-711763a. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the WordPress changes on this Pull Request by downloading it from AppCenter here with build number: pr18191-711763a. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@ScoutHarris ScoutHarris merged commit f4ec790 into release/19.5 Mar 23, 2022
@ScoutHarris ScoutHarris deleted the fix/cross_post_crash branch March 23, 2022 20:58
@mokagio
Copy link
Contributor

mokagio commented Mar 24, 2022

@ScoutHarris this has been bundled as part of 19.5 beta 1 (19.5.0.1).

Thanks for your work 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants