Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve VoiceOver experience when reordering menus #18155

Merged
merged 14 commits into from
Apr 8, 2022
Merged
Prev Previous commit
Next Next commit
Add a note to a11y hint about changing hierarchy.
twstokes committed Mar 20, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 16efa1750161e6033164ebd26a6413008edf028d
2 changes: 1 addition & 1 deletion WordPress/Classes/ViewRelated/Menus/MenuItemView.m
Original file line number Diff line number Diff line change
@@ -49,7 +49,7 @@ - (void)setupOrderingButton
UIImage *image = [[UIImage imageNamed:@"menus-move-icon"] imageWithRenderingMode:UIImageRenderingModeAlwaysTemplate];
UIButton *button = [self addAccessoryButtonIconViewWithImage:image];
button.accessibilityLabel = NSLocalizedString(@"Move menu item", @"Screen reader text for button that will move the menu item");
button.accessibilityHint = NSLocalizedString(@"Double tap and hold to move this menu item up or down", @"Screen reader hint for button that will move the menu item");
button.accessibilityHint = NSLocalizedString(@"Double tap and hold to move this menu item up or down. Move horizontally to change hierarchy.", @"Screen reader hint for button that will move the menu item");
button.userInteractionEnabled = NO;
// Override the accessibility traits so that VoiceOver doesn't read "Dimmed" due to userInteractionEnabled = NO
[button setAccessibilityTraits:UIAccessibilityTraitButton];