Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Comment Details: enable feature for release #18141

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Mar 15, 2022

Ref: #17790

This enables the new Comment details view for Comment Notifications.

To test:

TLDR - verify everything works as expected.

  • Go to Notifications > comment notification.
  • Verify the new details view is displayed.
  • Verify Spam, Trash, and deleted comments are removed from the notifications list.
  • Verify the ⬆️ and ⬇️ nav bar buttons display the previous and next notification.
  • Verify Edit, Reply, and Like work as expected.
  • Verify the You replied... message appears if you've replied to a comment.

If you do not have permission to the site the notification is for, verify:

  • The comment content appears.
  • The moderation bar does not.
  • Edit nav bar button does not.
  • Email address and IP address do not.
all_the_things some_things

Regression Notes

  1. Potential unintended areas of impact
    Should be done.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Tested Notification Comments and My Site Comments to be sure both work as expected.

  3. What automated tests I added (or what prevented me from doing so)
    Updated existing WP tests, new tests added to WPKit.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ScoutHarris ScoutHarris requested a review from dvdchr March 15, 2022 20:58
@ScoutHarris ScoutHarris marked this pull request as ready for review March 15, 2022 20:58
@wpmobilebot
Copy link
Contributor

You can test the Jetpack changes on this Pull Request by downloading it from AppCenter here with build number: pr18141-f5f0a87. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the WordPress changes on this Pull Request by downloading it from AppCenter here with build number: pr18141-f5f0a87. IPA is available here. If you need access to this, you can ask a maintainer to add you.

Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ScoutHarris ScoutHarris merged commit 43d47cc into trunk Mar 16, 2022
@ScoutHarris ScoutHarris deleted the feature/17790-enable_notif_comment_details branch March 16, 2022 18:33
@ScoutHarris ScoutHarris changed the title Notification Comment details: enable feature for release Notification Comment Details: enable feature for release Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants