Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Comment Details: hide back button title in threaded comments #18131

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Mar 11, 2022

Ref: #17790 , #18049

This removes the title from the back button in the threaded comments view.

To test:

  • Go to Notifications > Comments > comment details.
  • Tap the header to display the threaded comments.
  • Verify the nav bar back button does not have a title.
Before After
before after

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ScoutHarris ScoutHarris added this to the 19.5 milestone Mar 11, 2022
@ScoutHarris ScoutHarris self-assigned this Mar 11, 2022
@ScoutHarris ScoutHarris requested a review from dvdchr March 11, 2022 23:20
@ScoutHarris ScoutHarris marked this pull request as ready for review March 11, 2022 23:20
@ScoutHarris ScoutHarris changed the title Notification Comment Details: hide back button title on threaded comments view Notification Comment Details: hide back button title in threaded comments Mar 11, 2022
@wpmobilebot
Copy link
Contributor

You can test the Jetpack changes on this Pull Request by downloading it from AppCenter here with build number: pr18131-adfaa7d. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the WordPress changes on this Pull Request by downloading it from AppCenter here with build number: pr18131-adfaa7d. IPA is available here. If you need access to this, you can ask a maintainer to add you.

Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ScoutHarris ScoutHarris merged commit fb32af7 into trunk Mar 15, 2022
@ScoutHarris ScoutHarris deleted the feature/17790-back_button_text branch March 15, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants