Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Comment details: set background color to fix transition oddity #18082

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

ScoutHarris
Copy link
Contributor

Ref: #17790, #18064 (review)

This sets a background color on NotificationCommentDetailViewController to fix the issue where the Notifications list could be seen as the Comment loading view was transitioning in.

⚠️ Auto merge is enabled. ⚠️

To test:

  • Go to Notifications.
  • Select a Comment notification where the comment is not cached.
  • Verify, as the loading view is transitioning in, the Notifications list cannot be seen underneath.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

You can test the Jetpack changes on this Pull Request by downloading it from AppCenter here with build number: pr18082-957cde8. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the WordPress changes on this Pull Request by downloading it from AppCenter here with build number: pr18082-957cde8. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@ScoutHarris ScoutHarris merged commit 167f065 into trunk Mar 4, 2022
@ScoutHarris ScoutHarris deleted the feature/17790-set_background_color branch March 4, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants