Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: remove notification for deleted Comment #18028

Merged
merged 4 commits into from
Mar 1, 2022

Conversation

ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Feb 24, 2022

Ref: #17790, #18010 (review)

When a comment is deleted from My Site Comments, the corresponding notification is removed from the Notifications list. In split view, if the currently selected notification is removed, the first available notification is selected and displayed.

To test:

  • In split view, go to Notifications.
  • Select a Comment notification.
  • Go to My Sites tab > Comments.
  • Delete the comment for the selected notification.
  • Return to Notifications.
  • Verify:
    • The notification for the deleted comment is removed.
    • The first available notification is selected and the details are shown.
    • The table is responsive.
  • Disable notificationCommentDetails.
  • Repeat the steps above.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 25, 2022

You can test the Jetpack changes on this Pull Request by downloading it from AppCenter here with build number: pr18028-f0ebd08. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 25, 2022

You can test the WordPress changes on this Pull Request by downloading it from AppCenter here with build number: pr18028-f0ebd08. IPA is available here. If you need access to this, you can ask a maintainer to add you.

Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and everything works! LGTM! :shipit:

@ScoutHarris ScoutHarris enabled auto-merge March 1, 2022 19:11
@ScoutHarris ScoutHarris merged commit 759dafb into trunk Mar 1, 2022
@ScoutHarris ScoutHarris deleted the feature/17790-split_view_update_deleted branch March 1, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants