Notifications split view: set selected Notification after removing moderated #18002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #17790
This fixes an issue where, in split view, the Notification details could still be shown after the first Notification is removed from the list.
The problem was that
selectFirstNotificationIfAppropriate
was selecting the notification before it was updated. Now, instead of just clearingselectedNotification
,syncNotificationsWithModeratedComments
finds the next available notification and sets it as theselectedNotification
.Also, there is some code cleanup - the
CommentDetailViewController
protocols have been renamed to be more accurate.To test:
My Site
orReader
tab).Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.