Notifications > Comments: remove Notification when Comment is removed

[ScoutHarris]

Ref: #17790

When comments are moderated from the Notification Comment details view, the affected notifications are updated when the notifications list is re-shown. The effect is if a Comment is trashed, spammed, or deleted, its Notification is removed from the Notifications list.

In addition, comment moderation confirmation notices are no longer displayed for Notification comments.

Implementation notes:

If the Notification in NotificationsViewController is updated as soon as its Comment is trashed or spammed, the Notification will be removed from fetched results. This causes a couple of issues:

• In regular view, the nav bar previous/next buttons wouldn't find the previous/next notification.
• In split view, it would attempt to remove the notification as the user was possibly viewing it.

So the affected Notifications are tracked by NotificationCommentDetailCoordinator. NotificationsViewController syncs the Notifications when appropriate to update the Notifications list:

• In any view - when the Notifications list is shown (viewWillAppear).
• In split view - when another Notification is selected.

To test:

Regular View:

• Select a Comment notification.
  • In the details, select trash or spam.
  • Using previous/next nav bar buttons, trash/spam more Comment notifications.
  • Return to the Notifications list.
  • Verify all the Notifications for the trashed/spammed Comments are removed.
• Select a Comment notification.
  • In the details, select trash or spam, then Delete Permanently.
  • Verify the view is dismissed, and the notification is removed from the Notifications list.

Split View:

• Select a Comment notification.
  • In the details, select trash or spam.
  • Select another Notification.
  • Verify the Notification for the trashed/spammed Comment is removed from the list.
  • Note: Delete Permanently does not immediately nix the notification as in regular view. If you select another Notification, it will then be removed. I'll address this separately as it is related to the issue I commented on below.

Regression Notes

1. Potential unintended areas of impact

2. What I did to test those areas of impact (or what existing automated tests I relied on)

3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

You can test the Jetpack changes on this Pull Request by downloading it from AppCenter here with build number: pr17992-fb021f3. IPA is available here. If you need access to this, you can ask a maintainer to add you.

[wpmobilebot]

You can test the WordPress changes on this Pull Request by downloading it from AppCenter here with build number: pr17992-fb021f3. IPA is available here. If you need access to this, you can ask a maintainer to add you.

[ScoutHarris]

In split view, there is a legacy issue where, if you trash/spam a Comment while viewing it, the Notification is removed from the Notifications list but the details are still shown. Even though this PR improves that, it can still be seen by:

• In split view, trash/spam a comment.
• While still viewing the comment, navigate away from Notifications (ex: tap My Site or Reader tab).
• Come back to Notifications.
• The Notification is removed from the list, but the details is still displayed.

I'll look at this separately since it's not caused by this change.

[ScoutHarris]

I just realized this protocol name isn't really accurate with the new method I added. I'll make a note to rename it in a future PR.

[dvdchr]

Tested and it works as described. Changes are LGTM!

In split view, there is a legacy issue where, if you trash/spam a Comment while viewing it, the Notification is removed from the Notifications list but the details are still shown.
... I'll look at this separately since it's not caused by this change.

👍 .

I'd like to add that, for documentation purposes, this PR slightly changes the flow of comment moderation (especially related to Spam and Trash) in Notifications. Previously:

• When tapping Spam or Trash, the details view is immediately popped.
• In the Notifications list view, an undo overlay is displayed on top of the spammed/trashed Notification cell.
• The spam/trash action is only invoked from the list view after a certain timeout (Syncing.undoTimeout).
• Finally, the list view is refreshed to remove the notification cell.

I think the flow needed some adjustments here because the moderation logic is now invoked by the (new) detail view instead of the list view. This led to the core issue mentioned in the implementation notes and addressed by this PR,

If the Notification in NotificationsViewController is updated as soon as its Comment is trashed or spammed, the Notification will be removed from fetched results.