-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disables the Jetpack No Sites error for logins and signups #17948
Conversation
cc @ashiagr This PR disables the no sites error message for Jetpack app now, thanks for bringing this up! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emilylaguna One other thing -- we should update the release notes. (Thanks for the reminder @ashiagr!) |
@momo-ozawa I updated the image, and the release notes. Can I get another review please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image looks good! Left 1 minor suggestion.
Co-authored-by: Momo Ozawa <[email protected]>
Since we're allowing site creation we shouldn't display the no sites error if the user logs in or signs up.
This also fixes a small issue where the tapping on the 'Go to Reader' button from the Notifications.
To test:
No Sites Login
Signup
Regression Notes
Potential unintended areas of impact
None
What I did to test those areas of impact (or what existing automated tests I relied on)
None
What automated tests I added (or what prevented me from doing so)
None
PR submission checklist:
RELEASE-NOTES.txt
if necessary.