Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Share Sheet + image upload for images with copyright symbol from Photos app #17779

Closed
wants to merge 2 commits into from

Conversation

sla8c
Copy link
Contributor

@sla8c sla8c commented Jan 18, 2022

Fixes #16773

To test:

  1. Take any standard JPEG or PNG file and rename it with the filename crown-house_©-francesco-russo_websize_002-1-1, keeping the file’s extension.
  2. Ensure this above image is on your test simulator or device
  3. In the Photos app, choose the photo and launch the Share Sheet.
  4. Choose the WordPress iOS app so that this image is shared with the app. Create a new post.
  5. Result should be that Image with filename crown-house_©-francesco-russo_websize_002-1-1 should be uploaded to the chosen WordPress site and the image should render correctly on app and website in the Blog post

Regression Notes

  1. Potential unintended areas of impact
    Image filenames with unusual characters or encoding might not be uploaded

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    I tested images without the copyright symbol and other images and everything uploaded correctly

  3. What automated tests I added (or what prevented me from doing so)
    I added a unit test for sanitizing a filename with different filename variations including accents (diacritics)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@sla8c sla8c added this to the 19.1 milestone Jan 18, 2022
@sla8c sla8c requested a review from frosty January 18, 2022 11:10
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@sla8c sla8c closed this Jan 19, 2022
@sla8c sla8c deleted the issue/16773-image-filenames-share-sheet branch January 19, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to post images with certain filenames using Share Sheet from Photos app
1 participant