Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments: Track comment editor opened. #17685

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

ScoutHarris
Copy link
Contributor

This fixes an issue where opening the new edit Comment view was not tracked.

To test:

  • On a real device, go to My Site > Comments > Comment details > Edit.
  • Verify this is logged: 🔵 Tracked: comment_editor_opened <blog_id: xxx, comment_id: xxx, context: sites, post_id: xxx, site_type: blog>

Regression Notes

  1. Potential unintended areas of impact
    n/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@ScoutHarris
Copy link
Contributor Author

Thanks @dvdchr !

@ScoutHarris ScoutHarris merged commit f446576 into release/18.9 Dec 17, 2021
@ScoutHarris ScoutHarris deleted the fix/edit_comment_tracking branch December 17, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants