[Tooling] Disable widgets script on L10n download #17682
Conversation
…ng is still WIP We are currently working on removing `update-translations.rb` + `fix-translations` + `extract-framework-translations.swift` scripts from the repo and migrating their logic into the release-toolkit, but that work is still in progress. The role of the (misleadingly named) `extract-frameworks-translations.swift` script was to redistribute the keys from the `*.lproj/Localizable.strings` downloaded from GlotPress into the `.strings` files of the Widgets and ShareExtension targets, back when those targets used their own `.strings` file. This is no longer the case since #17630 and #17636 landed – as Widgets and ShareExtension's code now reference the app's `.strings` file directly – which means we don't need to run the logic from `extract-frameworks-translations.swift` anymore, and in fact if we did, it would probably crash now that the `Base.lproj/Localizable.strings` files in the Widgets and ShareExtension subfolders (which that script references) don't exist anymore.
|
You can trigger an installable build for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
There was a problem hiding this comment.
Since all this logic will soon be replaced by new actions I'm working on in the release-toolkit, I only focused on disabling what would crash for now, while still keeping the rest of the current tooling around until the new stuff is ready.
Makes sense, also considering this is a PR targeting a release branch, which we always try to keep as limited in scope as possible 👍
|
Update: When leaving my review, I didn't realize @AliSoftware would have been AFK today and till the new year. I'm going to merge this, then, to avoid it getting stale and to cover our basis in regards to:
|
As mentioned in #17672 (comment)
new_beta_releaseorfinalize_release.cc @jkmassel @mokagio You'll need to land this before running the next
new_beta_release— otherwise the lane will likely crash (on not finding the strings files for widgets anymore)Why?
Now that the Widgets & ShareExtension don't use their own
*.lproj/Localizable.stringsfiles (but instead reference the app bundle's one) — see #17630 & #17636 — this means we don't need to "redistribute" the strings downloaded from GlotPress from the main.stringsto the ones in the Widget target's subfolders (as those don't exist anymore).I am still working on porting the "download-from-glotpress-and-postprocess" part of the tooling to the release-toolkit and modernizing it by cleaning up the logic, but in the meantime, this PR just disables the call to
extract-framework-translations.swiftwhich was responsible for that "redistribution" of strings to Widgets, because it would otherwise fail and crash duringnew_beta_releaseandfinalize_releasewhen fetching the latest translations.This is because the
extract-framework-translations.swiftscript references theBase.lproj/Localizable.stringsfiles from the Widget and ShareExtension subfolders (so that it knew which keys to copy over), but those files no longer exists since #17630, #17636 and #17672, so the script would not be happy with them missing.Since all this logic will soon be replaced by new actions I'm working on in the release-toolkit, I only focused on disabling what would crash for now, while still keeping the rest of the current tooling around until the new stuff is ready.