Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow Conversation: Fix cases where the follow button is missing #17679

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

dvdchr
Copy link
Contributor

@dvdchr dvdchr commented Dec 16, 2021

Refs pbArwn-3hB-p2#comment-4533

This fixes the case where the Follow button is missing due to the Post object not being available initially but is not refreshed after the Post object is obtained.

To test

Comment threads from Notifications

  • Go to Notifications.
  • Select any comment notification.
  • Tap on the notification header to go to the comment threads.
  • 🔍 Verify that the Follow button appears after the loading completes.

Comment threads from Site Comments

  • Go to My Sites > Comments.
  • Select any reply comment.
  • Tap on the comment header to go to the comment threads.
  • 🔍 Verify that the Follow button appears after the loading completes.

Regression Notes

  1. Potential unintended areas of impact
    Should be none.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested to ensure that it is working properly.

  3. What automated tests I added (or what prevented me from doing so)
    n/a.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dvdchr dvdchr added this to the 18.9 ❄️ milestone Dec 16, 2021
@dvdchr dvdchr requested a review from ScoutHarris December 16, 2021 09:13
@dvdchr dvdchr self-assigned this Dec 16, 2021
@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@ScoutHarris ScoutHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Comment threads from Notifications
✅ Comment threads from Site Comments

:shipit:

@dvdchr dvdchr merged commit 146ce55 into release/18.9 Dec 17, 2021
@dvdchr dvdchr deleted the fix/missing-follow-button branch December 17, 2021 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants