Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments: Add tracking for comment sharing intent #17658

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

dvdchr
Copy link
Contributor

@dvdchr dvdchr commented Dec 9, 2021

Refs #17475

As titled, adds tracking for comment share intents:

  • reader_article_comment_shared when shared from the comment threads.
  • site_comments_comment_shared when shared from Site Comments.

To test

Site comments

  • Go to My Site > select any approved comments.
  • Tap on the Share button.
  • 🔍 Verify that this appears console: 🔵 Tracked: site_comments_comment_shared <>

Reader comments

  • Enable the newCommentThread feature flag.
  • Go to Notifications > select any comment notification.
  • Tap on the notification header to go to the comment threads.
  • Tap the share button (or if you can moderate, tap ellipsis button > Share).
  • 🔍 Verify that this appears in the console: 🔵 Tracked: reader_article_comment_shared <>

Regression Notes

  1. Potential unintended areas of impact
    Should be none.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested to ensure that the tracks are sent correctly.

  3. What automated tests I added (or what prevented me from doing so)
    n/a.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@ScoutHarris ScoutHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

:shipit:

@dvdchr dvdchr merged commit 99f6c4d into develop Dec 10, 2021
@dvdchr dvdchr deleted the issue/17475-tracking-share branch December 10, 2021 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants