Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple of About Screen issues #17646

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Conversation

frosty
Copy link
Contributor

@frosty frosty commented Dec 8, 2021

This PR fixes a couple of small issues with the new About screen.

  1. On some devices (only on device, and it doesn't show up on screenshots), a faint shimmering outline was visible around the app logos view:

I have only seen this on my 13 mini. This is now fixed by setting allowsTransparency to true on the SpriteKit view.

  1. The text in the header view didn't respond to dynamic type changes, so I've improved that. There's still an issue for the largest accessibility text size where a very large version number can get slightly truncated, but I spent a little while on it and it's much improved from what we had before.
Before After
Simulator Screen Shot - iPhone 13 Pro - 2021-12-08 at 15 46 37 Simulator Screen Shot - iPhone 13 Pro - 2021-12-08 at 14 38 07

To test

  • Build and run
  • Navigate to Me > About
  • Check the header looks as you'd expect, based on the Before screenshot above
  • Try changing the dynamic font sizes and ensure it looks okay
  • If you toggle it while the screen is visible, occasionally there may be a spacing issue below the header but it'll resolve itself if you reshow the view or change between other sizes.

Regression Notes

  1. Potential unintended areas of impact

None

  1. What I did to test those areas of impact (or what existing automated tests I relied on)
  2. What automated tests I added (or what prevented me from doing so)

N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

cc @mokagio

@frosty frosty added this to the 18.8 ❄️ milestone Dec 8, 2021
@frosty frosty requested a review from Gio2018 December 8, 2021 15:55
@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@Gio2018 Gio2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not have an iPhone 13 mini device, tested on iPhone 12 Pro Max and worked as expected.

@frosty frosty merged commit 9f6bd73 into release/18.8 Dec 8, 2021
@frosty frosty deleted the fix/about-screen-issues branch December 8, 2021 20:18
@mokagio
Copy link
Contributor

mokagio commented Dec 8, 2021

@frosty this has been bundled as part of 18.8 beta 4 (18.8.0.4), which is currently building in CI.

Thanks for your work 🙌

@frosty
Copy link
Contributor Author

frosty commented Dec 8, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants