Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tracking to the Add Site buttons #17612

Merged
merged 5 commits into from
Dec 2, 2021

Conversation

emilylaguna
Copy link
Contributor

Project: #17503

Description

This adds a new event when the Add Site Alert is displayed that includes a source of where it was tapped from. This also modifies the enhancedSiteCreationAccessed event to include a source.

To test:

  1. Login to an account with sites added
  2. Once you're logged in tap on the My Site tab
  3. Tap on the down arrow to open the site switcher
  4. Tap the + button
  5. Verify you see: 🔵 Tracked: add_site_alert_displayed <source: my_site>
  6. Tap on the 'Create a WP.com Site' button
  7. Verify you see 🔵 Tracked: enhanced_site_creation_accessed <source: my_sites>
  8. Exit out of the flow
  9. Logout, and sign back into your account
  10. Once you reach the new Login Epilogue to select a primary site, tap the 'Create Site' button at the bottom
  11. 🔵 Tracked: enhanced_site_creation_accessed <source: login_epilogue>
  12. Finish the flow, and logout again
  13. Create a new account
  14. Once you get to the post sign up epilogue view, tap the 'Create a WP.com site' button
  15. Verify you see 🔵 Tracked: enhanced_site_creation_accessed <source: signup_epilogue>
  16. Exit out of the site creation flow
  17. Tap on the My Site view
  18. Tap on the 'Add Site' button
  19. Verify you see: 🔵 Tracked: add_site_alert_displayed <source: my_site_no_sites>

Regression Notes

  1. Potential unintended areas of impact
    Objective-C null values being passed to nonnull Swift function.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Made the swift function nullable and added a check ?? check.

  3. What automated tests I added (or what prevented me from doing so)
    None.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 1, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described!

@emilylaguna emilylaguna merged commit e554d88 into develop Dec 2, 2021
@emilylaguna emilylaguna deleted the issue/17503-add-site-tracking branch December 2, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants