Adds tracking to the Add Site buttons #17612
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project: #17503
Description
This adds a new event when the Add Site Alert is displayed that includes a source of where it was tapped from. This also modifies the
enhancedSiteCreationAccessed
event to include a source.To test:
🔵 Tracked: add_site_alert_displayed <source: my_site>
🔵 Tracked: enhanced_site_creation_accessed <source: my_sites>
🔵 Tracked: enhanced_site_creation_accessed <source: login_epilogue>
🔵 Tracked: enhanced_site_creation_accessed <source: signup_epilogue>
🔵 Tracked: add_site_alert_displayed <source: my_site_no_sites>
Regression Notes
Potential unintended areas of impact
Objective-C null values being passed to nonnull Swift function.
What I did to test those areas of impact (or what existing automated tests I relied on)
Made the swift function nullable and added a check
??
check.What automated tests I added (or what prevented me from doing so)
None.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.