-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Reader detail headers with featured images on iOS 15 #17609
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this means that if a post has a featured image which happens to be mostly white (at least at the top part of the image), the NavBar buttons won't be visible either, because of the translucent appearance? |
@AliSoftware yes. I'd consider that an edge case though. However, if the user scrolls or tries the swipe-to-back gesture it will work. Anyway, this was the behavior before this issue. |
Yeah I just tested as well on my end, and even scrolling a couple of pixels will make the buttons appear again anyway. So |
This fix just got shipped into the new 18.8.0.3 on TestFlight 🎉 |
This PR fixes an issue where Reader Detail navigation bars for posts with featured images were white, which meant that buttons on the bar weren't visible.
To test
Regression Notes
Other navigation bars in the Reader.
I manually checked through various sections of the Reader to see that the navigation bar still looked as I expected.
None
PR submission checklist:
RELEASE-NOTES.txt
if necessary.