Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Reader detail headers with featured images on iOS 15 #17609

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

frosty
Copy link
Contributor

@frosty frosty commented Dec 1, 2021

This PR fixes an issue where Reader Detail navigation bars for posts with featured images were white, which meant that buttons on the bar weren't visible.

Before After
Simulator Screen Shot - iPhone 13 Pro - 2021-11-30 at 11 54 25 Simulator Screen Shot - iPhone 13 Pro - 2021-11-30 at 11 54 27

To test

  • Build and run
  • In Reader, head to Discover and find a post with a featured image at the top. Ensure that the navigation bar is clear and you can see the buttons.
  • Test on iOS 14 as well as 15 to check everything still looks as it should.
  • Double check some other areas of the Reader to see that this hasn't broken anything else there.

Regression Notes

  1. Potential unintended areas of impact

Other navigation bars in the Reader.

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

I manually checked through various sections of the Reader to see that the navigation bar still looked as I expected.

  1. What automated tests I added (or what prevented me from doing so)

None

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@frosty frosty added this to the 18.8 ❄️ milestone Dec 1, 2021
@frosty frosty requested a review from leandroalonso December 1, 2021 13:31
@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@leandroalonso leandroalonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AliSoftware
Copy link
Contributor

Does this means that if a post has a featured image which happens to be mostly white (at least at the top part of the image), the NavBar buttons won't be visible either, because of the translucent appearance?

@leandroalonso
Copy link
Contributor

@AliSoftware yes. I'd consider that an edge case though. However, if the user scrolls or tries the swipe-to-back gesture it will work.

Anyway, this was the behavior before this issue.

@AliSoftware
Copy link
Contributor

Yeah I just tested as well on my end, and even scrolling a couple of pixels will make the buttons appear again anyway. So :shipit:

@AliSoftware AliSoftware merged commit f21cef5 into release/18.8 Dec 2, 2021
@AliSoftware AliSoftware deleted the fix/reader-header branch December 2, 2021 16:23
@AliSoftware
Copy link
Contributor

This fix just got shipped into the new 18.8.0.3 on TestFlight 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants