-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader Comments: Overflow dropdown menu #17601
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
When viewing the new threaded comments, I see a slew of these in the logs: I don't see them with the old threaded comments. When the menu is shown, I see some of these as well: I honestly don't know what they mean 😄 , but can they be resolved? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments, but my request for changes is mainly due to the warnings produced by presentMenuForComment
.
WordPress/Classes/ViewRelated/Reader/ReaderCommentsViewController.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Reader/ReaderCommentsViewController.m
Outdated
Show resolved
Hide resolved
It looks like this is an issue with Xcode 13 targeting iOS 15. I've tried creating a standalone project that shows a menu, and the warning is still there. This doesn't appear when building for iOS 14.5, though!
After searching around, this also seems to be an issue specific to Xcode 13. This only appears when building for iOS 15. Ready for another round of review, thank you! 🙂 |
Thanks for looking into those warnings! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 !
Refs #17475
Depends on #17600
This PR adds the overflow dropdown menu when the content cell's accessory button is tapped while using an account with moderation roles. Some notes:
UIMenu
) on tap is only supported in iOS 14 and above. This can be achieved by setting theshowsMenuAsPrimaryAction
totrue
and assigning aUIMenu
to themenu
property ofUIButton
. Currently, tapping on the ellipsis button does nothing in iOS 13. I'll need to come up with a fallback implementation for iOS 13, and will address this in a separate PR.To Test
Ensure that the
newCommentThread
flag is enabled.With a moderator account:
Note: As noted above, in iOS 13.0, tapping on the ellipsis button will do nothing for now.
With a non-moderator account:
Regression Notes
Potential unintended areas of impact
n/a. The feature is hidden behind a flag.
What I did to test those areas of impact (or what existing automated tests I relied on)
n/a. The feature is hidden behind a flag.
What automated tests I added (or what prevented me from doing so)
n/a. The feature is hidden behind a flag.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.