-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty Stats: increase the threshold to 3000 #17590
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
@mokagio I wonder if it would be ok for you to merge that into the frozen branch. The change is quite small and as soon as we get data of this change, the better! |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
👍👍👍 |
Merged. I'm waiting for another fix to land in the release branch. If that doesn't happen in the next 24h, I'll ship a new beta just for this one. |
Thank you so much @mokagio! |
@leandroalonso his has been bundled as part of 18.8 beta 2 (18.8.0.2). Thanks for your work 🙌 |
Based on pbArwn-2HO-p2#comment-4413
This PR increases the maximum number of views to show the nudge cards to 3000.
To test
Regression Notes
Potential unintended areas of impact
n/a
What I did to test those areas of impact (or what existing automated tests I relied on)
n/a
What automated tests I added (or what prevented me from doing so)
n/a
PR submission checklist:
RELEASE-NOTES.txt
if necessary.