Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Stats: increase the threshold to 3000 #17590

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

leandroalonso
Copy link
Contributor

Based on pbArwn-2HO-p2#comment-4413

This PR increases the maximum number of views to show the nudge cards to 3000.

To test

  1. Do a fresh install
  2. Go to Stats
  3. For any sites with less than 3000 visitors the nudge should be shown

Regression Notes

  1. Potential unintended areas of impact
    n/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@leandroalonso leandroalonso changed the title Empty STats: increase the threshold to 3000 Empty Stats: increase the threshold to 3000 Nov 29, 2021
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@leandroalonso
Copy link
Contributor Author

@mokagio I wonder if it would be ok for you to merge that into the frozen branch. The change is quite small and as soon as we get data of this change, the better!

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@mokagio
Copy link
Contributor

mokagio commented Nov 30, 2021

@leandroalonso

as soon as we get data of this change, the better!

👍👍👍

@mokagio mokagio merged commit 39c2ccc into release/18.8 Nov 30, 2021
@mokagio mokagio deleted the task/bump_empty_stats_threshold branch November 30, 2021 02:22
@mokagio
Copy link
Contributor

mokagio commented Nov 30, 2021

Merged. I'm waiting for another fix to land in the release branch. If that doesn't happen in the next 24h, I'll ship a new beta just for this one.

@leandroalonso
Copy link
Contributor Author

Thank you so much @mokagio!

@mokagio
Copy link
Contributor

mokagio commented Dec 1, 2021

@leandroalonso his has been bundled as part of 18.8 beta 2 (18.8.0.2).

Thanks for your work 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants