-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WPMediaPicker from version 1.7.2 to 1.8.0-beta.1 #17584
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
The update I made to the library was to avoid a crash when I checked the WPiOS app, and it wasn't susceptible to this crash because it implements |
Sergio and I opted for 1.8.0 for his set of changes as they bumped the minimum supported version of iOS, so we felt it warranted a bigger version bump than just a bugfix release. I'm not sure why this was replaced by 1.7.3, however? |
Nah, that's okay. I think it should be up to the WP iOS devs and us release train conductors to monitor and update the libraries as they change, if necessary. I mean, it would not have been wrong for you to open a PR to update it here, too, since the change was safe, but we can't expect library authors to updated every downstream consumer. It doesn't scale.
🤔 I went for 1.7.3 because that's what the I think both "issues" are due to this repo not being part of the list we (I?) check a part of the code freeze. I'll make sure to add it from now on. 😅 |
fa4102f
to
82105c6
Compare
This is a routine update prompted by a step in our release process checklist. @jkmassel @joshheald @frosty you folks are the last to have interacted with the library. Jeremy and Josh [on Woo](woocommerce/woocommerce-ios#5138) and [the lib itself](wordpress-mobile/MediaPicker-iOS@1.7.2...1.7.3) and Frosty here, 0b3c392. Can you tell me if there's a reason why this was never update, and no one raised an issue about it? Two possibilities: - I missed it since its release, or like in the previous release cycle, simply run out of time for this - There's no reason to upgrade, so no dev did it If it's the latter, then feel free to close this PR. I also noticed @SergioEstevao [bumped](https://github.com/wordpress-mobile/MediaPicker-iOS/blob/56371391da9fc7ea1350b9808af8b4d2f67ecbfd/WPMediaPicker.podspec#L5) the library to 1.8.0-beta.1 (although, there's no tag for it, yet). So let me know if it would be better to use that beta here instead.
82105c6
to
d5357a1
Compare
@frosty @SergioEstevao @joshheald I bumped the library to 1.8.0-beta.1, can you have another look please? 🙏 🙇♂️ |
This is a routine update prompted by a step in our release process checklist.
@jkmassel @joshheald @frosty you folks are the last to have interacted with the library. Jeremy and Josh on Woo and the lib itself and Frosty here, 0b3c392. Can you tell me if there's a reason why this was never update, and no one raised an issue about it?
Two possibilities:
If it's the latter, then feel free to close this PR.
I also noticed @SergioEstevao bumped the library to 1.8.0-beta.1 (although, there's no tag for it, yet). So let me know if it would be better to use that beta here instead.
Regression Notes
Potential unintended areas of impact
The media picking workflow, I guess? The version has been out for a while and used in Woo, so it should be safe-ish to adopt here, too.
What I did to test those areas of impact (or what existing automated tests I relied on)
N.A.
What automated tests I added (or what prevented me from doing so)
N.A.
RELEASE-NOTES.txt
if necessary. N.A.