Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding Improvements: Reuse Post Sign-up Interstitial if there's no sites #17578

Merged

Conversation

momo-ozawa
Copy link
Contributor

Ref: #17520 (comment)

Description

This PR simplifies the Login flow for when there's no sites yet by reusing the Post Sign-up Interstitial screen.

Login logic for when there's no site yet:

  • Before: Post Post Sign-up Interstitial screen shown on first login, and no sites Epilogue variation shown on subsequent logins
  • After: Post Sign-up Interstitial screen shown on every login
Before After

How to test

  1. Log out / log in to a site w no sites
  2. ✅ Make sure you see the Post Signup Interstitial screen
  3. Repeat steps 1,2
  4. ✅ Make sure you see the Post Signup Interstitial screen again

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 26, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@leandroalonso leandroalonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Tested with WP and JP, no-sites and with sites.

@mokagio
Copy link
Contributor

mokagio commented Nov 28, 2021

I'm going to merge this PR because it's been approved and has the 18.8 milestone, which is the code freeze I'll be starting today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants