Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents the image size change from tracking each value continuously #17523

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Prevents the image size change from tracking each value continuously #17523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions WordPress/Classes/ViewRelated/Me/App Settings/AppSettingsViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,13 +148,20 @@ class AppSettingsViewController: UITableViewController {
MediaSettings().maxImageSizeSetting = value
ShareExtensionService.configureShareExtensionMaximumMediaDimension(value)

var properties = [String: AnyObject]()
properties["enabled"] = (value != Int.max) as AnyObject
properties["value"] = value as Int as AnyObject
WPAnalytics.track(.appSettingsImageOptimizationChanged, withProperties: properties)
self.debounce(#selector(self.trackImageSizeChanged), afterDelay: 0.5)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

}
}

@objc func trackImageSizeChanged() {
let value = MediaSettings().maxImageSizeSetting

var properties = [String: AnyObject]()
properties["enabled"] = (value != Int.max) as AnyObject
properties["value"] = value as Int as AnyObject

WPAnalytics.track(.appSettingsImageOptimizationChanged, withProperties: properties)
}

func pushVideoResolutionSettings() -> ImmuTableAction {
return { [weak self] row in
let values = [MediaSettings.VideoResolution.size640x480,
Expand Down