Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tracking to the Post List Share option #17522

Merged
merged 3 commits into from
Nov 23, 2021

Conversation

emilylaguna
Copy link
Contributor

Project: #17503

Description

Adds tracking when you tap the 'Share' option from the More menu on the post list view

To test:

Filter Sheet

  1. Launch the app
  2. Tap on My Site
  3. Tap on Posts
  4. Tap the ⋯ More button
  5. Tap the Share item
  6. Verify you see: 🔵 Tracked: post_list_button_pressed <blog_id: BLOG_ID, button: share, filter: Published, type: post>

Regression Notes

  1. Potential unintended areas of impact
    None, adding tracking.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    None.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 22, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 22, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@frosty frosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@emilylaguna emilylaguna merged commit d5d89fb into develop Nov 23, 2021
@emilylaguna emilylaguna deleted the issue/17503-post-list-share-action branch November 23, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants